fix(service): validate cron schedule before create_cron_job API call - #34
Open
aniruddhaadak80 wants to merge 1 commit into
Open
aniruddhaadak80 wants to merge 1 commit into
aniruddhaadak80 wants to merge 1 commit into
Conversation
create_cron_job forwarded any schedule string to the Render API, so typos like everyday surfaced as opaque downstream errors. Validate the 5-field expression locally (ranges, wildcards, ranges, steps, lists, JAN-DEC and SUN-SAT names) and return a clear tool error naming the bad field. Fixes render-oss#31
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
create_cron_job accepted any schedule string and forwarded it to the Render API, so a typo like everyday or 99 99 * * * only failed downstream as an opaque API error. Local validation fails fast with the expected 5-field format hint.
Repro (before fix): createValidatedCronJobRequest with schedule everyday returned no error and proceeded to the API call. After fix it returns invalid schedule expression.
How tested
Fixes #31