refactor(VMPromising): Track translation snapshot ranges - #189
Open
febyeji wants to merge 1 commit into
Open
Conversation
febyeji
force-pushed
the
vmp-snapshot-ranges
branch
2 times, most recently
from
July 4, 2026 07:14
8c61180 to
b3d28ac
Compare
tperami
reviewed
Jul 4, 2026
febyeji
force-pushed
the
vmp-snapshot-ranges
branch
3 times, most recently
from
July 4, 2026 14:32
730f197 to
0093769
Compare
febyeji
force-pushed
the
vmp-snapshot-ranges
branch
from
July 5, 2026 22:54
88422d0 to
290c5e5
Compare
Collaborator
|
Whwwhsewb |
febyeji
force-pushed
the
vmp-snapshot-ranges
branch
from
July 17, 2026 21:31
290c5e5 to
3c25338
Compare
tperami
approved these changes
Jul 22, 2026
tperami
left a comment
Collaborator
There was a problem hiding this comment.
Good to go after removing distinct check and fixing the other comment
- Attach start/end ranges to unique VA TLB snapshots after construction. - Carry translation start/end bounds in TransRes so selected translations retain their snapshot range metadata. - Delay ETS3 fault timing within the selected translation snapshot range.
febyeji
force-pushed
the
vmp-snapshot-ranges
branch
from
July 23, 2026 03:12
3c25338 to
d7f0d84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an ETS2 invalid-PTE case and adds snapshot optimisation. The motivating test is
R+rel+lws-mmufault-po, which expectsForbiddenin the VMSA-ETS2 kind, while the old ArchSem behavior could produceno-behaviour.Before this patch, the invalid
zfault candidate was only seen from the initial snapshot (trans_time = 0). AfterSTR y = 2advanced the write view, ETS2 rejected that stale0 < vwrcandidate, leaving no invalid translation candidate forSTR z.This patch:
Ref: Arm ARM DDI0487M.c B2.3 treats Translation Fault Effects as
TLBUncacheable, andFEAT_ETS2orders the implicit TTD read before such a fault, so the invalid PTE read must be selected from a sufficiently late snapshot.