split pm_fedem into industry and buildings#2329
Open
fbenke-pik wants to merge 16 commits into
Open
Conversation
fbenke-pik
commented
Apr 14, 2026
fbenke-pik
commented
Apr 14, 2026
fbenke-pik
commented
Apr 14, 2026
fbenke-pik
commented
Apr 15, 2026
fbenke-pik
commented
Apr 15, 2026
fbenke-pik
commented
Apr 15, 2026
fbenke-pik
commented
Apr 15, 2026
fbenke-pik
commented
Apr 15, 2026
fbenke-pik
commented
Apr 15, 2026
1b883e2 to
c971989
Compare
2 tasks
|
|
||
| #### Current input data revision (<mainrevision>.<subrevision>) #### | ||
| cfg$inputRevision <- "7.91" | ||
| cfg$inputRevision <- "7.90fedem" |
Member
There was a problem hiding this comment.
could we use an input data rev. number which has no extention?
Contributor
Author
There was a problem hiding this comment.
Yes, once this is approved, I will make a new input data version without the dev extension
| f_fedemandBuild(tall,all_regi,all_demScen,all_rcp_scen,all_in) "RCP-dependent final energy demand in buildings" | ||
| / | ||
| $ondelim | ||
| $include "./core/input/f_fedemand_build.cs4r" |
Member
There was a problem hiding this comment.
same names for the parameter and the files would be better
| / | ||
| $ondelim | ||
| $include "./core/input/f_fedemand.cs4r" | ||
| $include "./core/input/f_fedemand_ind.cs4r" |
Member
There was a problem hiding this comment.
same name for the parameter and the file would be bestter, always f_fedemandInd
| @@ -1,3 +1,2 @@ | |||
| f36_floorspace_scen.cs4r | |||
| f36_uedemand_build.cs4r | |||
| f_fedemand_build.cs4r | |||
Member
There was a problem hiding this comment.
this file is not subsituted by another file in teh buildings module?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)
/p/tmp/benke/model/remind_buildings/p/tmp/benke/model/remind_buildings/compScen-calib-2026-05-28_11.46.18-H12.pdf/p/tmp/benke/model/remind_buildings/compScen-infes-2026-05-26_11.58.57-H12.pdf/p/tmp/benke/model/remind_buildings/compScen-ssp2-eu21-2026-05-22_14.16.24-H12.pdf