fix(notify): honour the smtp timeout, TLS and auth params - #990
Draft
JosephKav wants to merge 2 commits into
Draft
fix(notify): honour the smtp timeout, TLS and auth params#990JosephKav wants to merge 2 commits into
JosephKav wants to merge 2 commits into
Conversation
timeout, encryption, and skiptlsverify now travel in the built URL as Shoutrrr can't parse a duration from the params and dials with the config it parsed from the URL.
- gotify, mattermost, ntfy, and zulip
JosephKav
added
javascript
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #990 +/- ##
==========================================
+ Coverage 99.71% 99.71% +0.01%
==========================================
Files 204 204
Lines 13027 13053 +26
==========================================
+ Hits 12989 13015 +26
Misses 33 33
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
✅ Playwright Test Results
Duration: 1355.7s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timeout,encryption, andskiptlsverifywere ignored by the SMTP notifier.Shoutrrr reflects send-params onto its config with
strconv.ParseInt, so aduration errors there, and
getClientConnectiondials with the config parsedfrom the URL while the params only reach a clone used afterwards. Moving the
three to the built URL fixes all of them.
auth: Unknownwas a separate break. Shoutrrr resolves it to "Plain/None" whileparsing the URL, then
Sendre-applies the params and restores it, sogetAuthfails.