Skip to content

Remove Sui support#1035

Merged
ted-palmer merged 4 commits into
mainfrom
ted/fe-8528-remove-sui-from-sdk-ui-kit-and-adapter
Jun 19, 2026
Merged

Remove Sui support#1035
ted-palmer merged 4 commits into
mainfrom
ted/fe-8528-remove-sui-from-sdk-ui-kit-and-adapter

Conversation

@ted-palmer

Copy link
Copy Markdown
Collaborator

No description provided.

@ted-palmer ted-palmer requested a review from pedromcunha June 18, 2026 16:10
@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
relay-sdk-demo Ready Ready Preview, Comment Jun 19, 2026 1:36pm

Request Review

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ted-palmer's task in 1m 34s —— View job


Code Review — 3 note(s) found

The Sui removal is clean and consistent. I verified there are no leftover references to suivm, adaptSuiWallet, isSuiWallet, useSuiBalance, SuiReceipt, suiDeadAddress, or relay-sui-wallet-adapter anywhere in the source — the union-member removals (ChainVM, AdaptedWallet, receipt types) are safe because no remaining code consumes them. Package, hooks, utils, lockfile, and demo wiring are all removed coherently.

A few completeness leftovers (all low severity — none break the build or runtime):

  1. NOTE — Completeness: auto-generated file edited by hand
    packages/sdk/src/types/api.ts:309,10149,10205,10301,10332 — this file is marked "auto-generated by openapi-typescript. Do not make direct changes." The "suivm" removals from the vmType enums were applied manually. If the upstream OpenAPI schema still emits suivm, the next pnpm syncSdkTypes run will reintroduce it. Confirm the API schema has dropped suivm so the sync stays in agreement (the "sui" gasCurrency enum on line 601 was left intact, which is correct if Sui gas currency is still returned).

  2. NOTE — Completeness: stale Sui reference in demo sponsored-token lists
    demo/pages/ui/swap.tsx:228 and demo/pages/api/secure/[...path].ts:10 still list the Sui USDC token 103665049:0x…::usdc::USDC in usdcSponsoredTokens. Harmless (a Sui token can no longer be selected, so it just never matches), but it's dead config given the PR's goal.

  3. NOTE — Docs drift
    .github/workflows/docs-drift-check.yml:118 still lists Sui in the set of public wallet-adapter interfaces. Worth updating to match the removal. (I can't modify files under .github/workflows/ myself due to app permissions.)

Reviewed 34 files, ~957 lines changed. Checked correctness, error handling, security, and repo guidelines.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ted-palmer's task in 1m 14s —— View job


📝 Docs Drift Check — No docs impact

This PR removes Sui support from RelayKit (the relay-sui-wallet-adapter package, the suivm ChainVM/vmType value, and related SDK/UI types). However, the published relayprotocol/relay-docs pages never documented Sui: no Sui/suivm references exist under references/relay-kit/**, the adapters reference lists only SVM, Bitcoin, Viem, Ethers, Tron, and Lighter, and its vmType table already shows only evm svm bvm tvm lvm. There is no stale or missing documentation introduced by this change.

pedromcunha
pedromcunha previously approved these changes Jun 18, 2026
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ted-palmer's task in 1m 22s —— View job


Code Review — 1 note found

I reviewed the full diff (git diff origin/main...HEAD) and verified the surrounding source. The Sui removal is clean and internally consistent:

  • ✅ No leftover references to suivm, adaptSuiWallet, isSuiWallet, useSuiBalance, SuiReceipt, suiDeadAddress, isSuiAddress, or relay-sui-wallet-adapter anywhere in source (only historical CHANGELOG.md entries remain, which is correct).
  • ✅ Union-member removals (ChainVM, AdaptedWallet, receipt types, getDeadAddress/isDeadAddress, isValidAddress, addressesEqual) are safe — no remaining code consumes the removed branches.
  • useCurrencyBalance no longer wires up useSuiBalance, and the deleted useSuiBalance.ts / utils/sui.ts have no remaining importers.
  • ✅ Build wiring (build:adapter), pnpm-lock.yaml, demo wallet config, and the WALLET_VM_TYPES/walletFilter unions are all updated coherently.
  • ✅ The two earlier-flagged completeness leftovers are now resolved in this revision: the Sui USDC sponsored token is gone from both demo/pages/ui/swap.tsx and demo/pages/api/secure/[...path].ts, and docs-drift-check.yml no longer lists Sui.
  • @dynamic-labs/sui-core correctly remains in the lockfile — it's a transitive dependency of @dynamic-labs/waas (pulled in by the Solana connectors), not an orphan.

1. NOTE — Completeness: manual edit to an auto-generated file
packages/sdk/src/types/api.ts:309,10149,10205,10301,10332 — this file is marked "auto-generated by openapi-typescript. Do not make direct changes." The "suivm" removals from the vmType enums were applied by hand. If the upstream OpenAPI schema still emits suivm, the next pnpm syncSdkTypes run will reintroduce it. Worth confirming the API schema has actually dropped suivm so the sync stays in agreement. (The "sui" value in the gasCurrency enum on line 601 was correctly left intact — that's a separate field the API still returns.)

Reviewed 36 files, ~957 lines changed. Checked correctness, error handling, security, and repo guidelines.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ted-palmer's task in 49s —— View job


📝 Docs Drift Check — No docs impact

This PR removes Sui support from RelayKit (the relay-sui-wallet-adapter package, the suivm ChainVM/vmType value, and related SDK/UI types and balance hooks). It touches doc-relevant surfaces, but the published relayprotocol/relay-docs pages never documented Sui: no Sui/suivm references exist under references/relay-kit/**, the adapters reference lists only SVM, Bitcoin, Ethers, Tron, and Lighter, and its vmType table already shows only evm svm bvm tvm lvm. The remaining Sui hits in the docs repo are unrelated (protocol/oracle pages about Sui-the-chain). No stale or missing documentation is introduced by this change.

@ted-palmer ted-palmer merged commit 4149ded into main Jun 19, 2026
6 checks passed
@ted-palmer ted-palmer deleted the ted/fe-8528-remove-sui-from-sdk-ui-kit-and-adapter branch June 19, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants