fix(cli): drop autotools build dependency now that libpff builds from a release tarball#450
Merged
Merged
Conversation
… a release tarball PR #443 switched libpff to libyal's release tarball, which ships a pre-generated `configure`, removing the autoconf/automake requirement. This removes the now-dead autotools scaffolding from the build scripts, CI workflows, and README. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #443 switched the libpff build (PST parsing) from cloning libyal via
synclibs.sh/autogen.shto libyal's release tarball, which ships apre-generated
configure— removing the autoconf/automake (autotools) buildrequirement. That shipped in v0.40.0 (crates.io now at 0.41.x). This PR is the
follow-up cleanup that removes the now-dead autotools scaffolding.
Verified locally on macOS with autoconf/automake absent and no MacPorts: a
clean from-scratch libpff build (download tarball → vendored
./configure→make) succeeds, so the dropped tooling is genuinely unused.Changes
scripts/build-install— Ubuntu path dropsautoconf/automake/autopoint/libtool(keeps
pkg-config+musl-tools); macOS path drops the MacPorts bootstrapentirely (C compiler +
makecome from the preinstalled Xcode CLT)..github/workflows/rust.yml— remove autotools (and the now-deadgit,previously needed by
synclibs.sh) from the clippyapt install; drop themacOS MacPorts setup step and the stale
cli/libpff-20231205//opt/localcache paths.
.github/workflows/publish.yml— drop the same macOS setup step and stalecache paths.
README.md— replace the autotools/MacPorts install instructions with thedeps actually required to build from source (
build-essential pkg-config curl zlib1g-devon Debian/Ubuntu; Xcode CLT on macOS).CHANGELOG.md— add an# Unreleasedentry.Closes RE-12487.
🤖 Generated with Claude Code