Move aar_init_script off legacy AGP APIs - #9
Open
reidbaker-agent wants to merge 1 commit into
Open
Conversation
reidbaker-agent
force-pushed
the
agp-aar-script
branch
from
July 22, 2026 15:54
27bf63d to
4b3f4e5
Compare
reidbaker-agent
force-pushed
the
agp-add-to-app
branch
from
July 28, 2026 13:36
d384683 to
190cb3b
Compare
reidbaker-agent
force-pushed
the
agp-aar-script
branch
from
July 28, 2026 13:36
4b3f4e5 to
594f593
Compare
reidbaker-agent
force-pushed
the
agp-add-to-app
branch
from
July 28, 2026 13:37
190cb3b to
f861ab5
Compare
reidbaker-agent
force-pushed
the
agp-aar-script
branch
from
July 28, 2026 13:37
594f593 to
2e64d7a
Compare
reidbaker-agent
force-pushed
the
agp-add-to-app
branch
from
July 29, 2026 20:22
f861ab5 to
82d9979
Compare
reidbaker-agent
force-pushed
the
agp-aar-script
branch
from
July 29, 2026 20:22
2e64d7a to
bb22914
Compare
reidbaker-agent
force-pushed
the
agp-add-to-app
branch
from
July 29, 2026 20:44
82d9979 to
49bc8bd
Compare
reidbaker-agent
force-pushed
the
agp-aar-script
branch
2 times, most recently
from
July 30, 2026 21:58
65bafb0 to
39f0c33
Compare
reidbaker-agent
force-pushed
the
agp-add-to-app
branch
from
July 31, 2026 16:16
645fe6f to
a4a3dbd
Compare
reidbaker-agent
force-pushed
the
agp-aar-script
branch
from
July 31, 2026 16:16
39f0c33 to
89849d6
Compare
Phase P8 of the AGP public-API migration (flutter#180137, flutter#166550): - The library-project check no longer probes for the legacy android.libraryVariants property (absent under the new DSL); it checks for the com.android.library plugin. Error message unchanged. - The plugin-to-module assembleAar task wiring enumerates published variants through the public software components (which the script already used for task creation) instead of libraryVariants. - The singleVariant dedup guard no longer reads the internal publishing.singleVariants collection. Flutter now marks projects it configured with an ext property and declares each variant's publishing in a try-catch: when the project's own build file already declared publishing for a variant, the user's declaration wins and a warning explains the situation and the fix. (Previously any user-declared variant silently disabled Flutter's publishing setup for ALL variants, which broke partially-declared projects at publication time with no explanation.) Verification (CI): flutter build aar with and without flavors for module and plugin projects; AAR-host add-to-app flow; a scratch module with a partial user singleVariant declaration; newDsl=true aar flow. Revert-safe even after P10, but not after P9.
reidbaker
force-pushed
the
agp-add-to-app
branch
from
July 31, 2026 18:07
a4a3dbd to
447a829
Compare
reidbaker
force-pushed
the
agp-aar-script
branch
from
July 31, 2026 18:07
89849d6 to
4a8e3a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 9 of 11 of the AGP public-API migration; stacked on #8.
Phase P8 of the AGP public-API migration (flutter#180137,
flutter#166550):
android.libraryVariants property (absent under the new DSL); it
checks for the com.android.library plugin. Error message unchanged.
variants through the public software components (which the script
already used for task creation) instead of libraryVariants.
publishing.singleVariants collection. Flutter now marks projects it
configured with an ext property and declares each variant's
publishing in a try-catch: when the project's own build file already
declared publishing for a variant, the user's declaration wins and a
warning explains the situation and the fix. (Previously any
user-declared variant silently disabled Flutter's publishing setup
for ALL variants, which broke partially-declared projects at
publication time with no explanation.)
Verification (CI): flutter build aar with and without flavors for
module and plugin projects; AAR-host add-to-app flow; a scratch module
with a partial user singleVariant declaration; newDsl=true aar flow.
Revert-safe even after P10, but not after P9.
CI must run the FGP unit tests (the Kotlin suite in packages/flutter_tools/gradle could not run in the delivery sandbox: dl.google.com returns 403, so AGP artifacts do not resolve).