Compile the Flutter Gradle Plugin against the gradle-api artifact only - #11
Open
reidbaker-agent wants to merge 2 commits into
Open
Compile the Flutter Gradle Plugin against the gradle-api artifact only#11reidbaker-agent wants to merge 2 commits into
reidbaker-agent wants to merge 2 commits into
Conversation
reidbaker-agent
force-pushed
the
agp-newdsl-flip
branch
from
July 22, 2026 15:54
1c7628d to
90e7f64
Compare
reidbaker-agent
force-pushed
the
agp-gradle-api
branch
from
July 22, 2026 15:54
6f3cbbb to
334d7fa
Compare
reidbaker-agent
force-pushed
the
agp-newdsl-flip
branch
from
July 28, 2026 13:36
90e7f64 to
e677b61
Compare
reidbaker-agent
force-pushed
the
agp-gradle-api
branch
from
July 28, 2026 13:36
334d7fa to
c33ae34
Compare
reidbaker-agent
force-pushed
the
agp-newdsl-flip
branch
from
July 28, 2026 13:37
e677b61 to
0469863
Compare
reidbaker-agent
force-pushed
the
agp-gradle-api
branch
from
July 28, 2026 13:38
c33ae34 to
e968545
Compare
reidbaker-agent
force-pushed
the
agp-newdsl-flip
branch
from
July 29, 2026 20:23
0469863 to
0c85338
Compare
reidbaker-agent
force-pushed
the
agp-gradle-api
branch
from
July 29, 2026 20:25
13bc17f to
a0ab835
Compare
reidbaker-agent
force-pushed
the
agp-newdsl-flip
branch
from
July 29, 2026 20:45
0c85338 to
45274d4
Compare
reidbaker-agent
force-pushed
the
agp-gradle-api
branch
3 times, most recently
from
July 31, 2026 16:16
ef2c92a to
154cdcd
Compare
reidbaker-agent
force-pushed
the
agp-newdsl-flip
branch
from
July 31, 2026 16:16
a850013 to
aae8462
Compare
Phase P10, the final phase of the AGP public-API migration (flutter#180137, flutter#166550): - build.gradle.kts swaps both AGP dependencies from the full com.android.tools.build:gradle artifact to com.android.tools.build:gradle-api. Compilation is now the proof that the plugin uses zero AGP internals (AGP 10 removes access to them entirely), on top of the InternalAgpApiImportTest source check and the validateNoCommonExtensionInBytecode bytecode check, which stay as fast-feedback guards. - FlutterPluginTest is rewritten on public-API mocks only: the AbstractAppExtension multi-interface mock, BaseExtension, CommonExtension, internal.dsl.DefaultConfig, and the legacy sourceSets/AndroidSourceDirectorySet mocks are gone. No test source references a full-artifact-only or internal type anymore. - The --android-skip-build-dependency-validation help text now warns that skipping validation cannot make unsupported AGP versions work: builds below the supported minimum fail in Gradle regardless. - The android tooling README gains the AGP-bump checklist step to run the FGP test suite against the new version's public API artifact (-PagpVersion axis) and links the migration doc. Verification (CI): full matrix per the migration doc (gradle unit tests on both AGP axes - now both against gradle-api; scratch-app matrix; add-to-app source/AAR flows; config-cache baseline). Dart analyzer clean on the changed tool file. Cleanly revertible in isolation.
reidbaker
force-pushed
the
agp-gradle-api
branch
from
July 31, 2026 18:07
154cdcd to
a8575b4
Compare
reidbaker
force-pushed
the
agp-newdsl-flip
branch
from
July 31, 2026 18:07
aae8462 to
7b8bdf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 11 of 11 of the AGP public-API migration; stacked on #10.
Phase P10, the final phase of the AGP public-API migration
(flutter#180137, flutter#166550):
com.android.tools.build:gradle artifact to
com.android.tools.build:gradle-api. Compilation is now the proof that
the plugin uses zero AGP internals (AGP 10 removes access to them
entirely), on top of the InternalAgpApiImportTest source check and
the validateNoCommonExtensionInBytecode bytecode check, which stay as
fast-feedback guards.
AbstractAppExtension multi-interface mock, BaseExtension,
CommonExtension, internal.dsl.DefaultConfig, and the legacy
sourceSets/AndroidSourceDirectorySet mocks are gone. No test source
references a full-artifact-only or internal type anymore.
that skipping validation cannot make unsupported AGP versions work:
builds below the supported minimum fail in Gradle regardless.
the FGP test suite against the new version's public API artifact
(-PagpVersion axis) and links the migration doc.
Verification (CI): full matrix per the migration doc (gradle unit tests
on both AGP axes - now both against gradle-api; scratch-app matrix;
add-to-app source/AAR flows; config-cache baseline). Dart analyzer
clean on the changed tool file.
CI must run the FGP unit tests (the Kotlin suite in packages/flutter_tools/gradle could not run in the delivery sandbox: dl.google.com returns 403, so AGP artifacts do not resolve).