This repository was archived by the owner on Apr 8, 2023. It is now read-only.
Improve "Create" button behavior - #10
Closed
kusomaigo wants to merge 3 commits into
Closed
Conversation
…arameter behavior when isCombined is false
…cution logic and minor UI change
…meter layer GUI button if block
Contributor
Author
|
I was notified of the bug in the latest pre-release unity package from https://discord.com/channels/849300336128032789/922962294210711594/1061127730550292560 and ended up making more changes 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various fixes to the behavior of the "Create" button, including fix for the "create parameter" toggle similar to Jerry's PR #9. This is a more comprehensive rewrite of that segment of code in BinaryParameterWindow.cs. Tool behavior should now be more logical across tool setting permutations.
Also contains code not in the git branch but in the latest unity package release that causes a
Collection was modified enumeration operation may not executeerror. Code has since been fixed and renamed, but is currently not utilized.