Skip to content

[bugfix] Treat properly Slurm constraints with .#3667

Merged
vkarak merged 1 commit into
reframe-hpc:developfrom
Guy-Coates:constraint-fix-master
May 19, 2026
Merged

[bugfix] Treat properly Slurm constraints with .#3667
vkarak merged 1 commit into
reframe-hpc:developfrom
Guy-Coates:constraint-fix-master

Conversation

@Guy-Coates
Copy link
Copy Markdown
Contributor

The reframe slurm node constraint validator rejects features with a "." in the name (eg nodes with Feature=c5.xlarge defined in slurm).

This results in Reframe generating no tests when attempting to target nodes of that type using --constraint=c5.xlarge in the systems.partitions.access config.

This PR relaxes the validation/tokenisation regexes to allow ".".

@vkarak vkarak requested review from jack-morrison and vkarak May 18, 2026 21:49
@vkarak vkarak requested review from ekouts and removed request for ekouts and jack-morrison May 18, 2026 21:49
@vkarak vkarak moved this to In Progress in ReFrame Backlog May 18, 2026
@vkarak vkarak moved this from In Progress to Todo in ReFrame Backlog May 18, 2026
@vkarak vkarak added this to the ReFrame 4.10 milestone May 18, 2026
@vkarak vkarak changed the title [bugfix] Allow "." in slurm features [bugfix] Treat properly Slurm constraints with . May 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.95%. Comparing base (94bae27) to head (8d86d40).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3667   +/-   ##
========================================
  Coverage    91.95%   91.95%           
========================================
  Files           62       62           
  Lines        13762    13762           
========================================
  Hits         12655    12655           
  Misses        1107     1107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Lgtm. Since we are not going to make another patch release for 4.9 (4.10 is around the corner), we'd need to rebase this PR on develop.

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in ReFrame Backlog May 18, 2026
@vkarak vkarak force-pushed the constraint-fix-master branch from f824600 to 8d86d40 Compare May 19, 2026 20:37
@vkarak vkarak changed the base branch from master to develop May 19, 2026 20:38
Copy link
Copy Markdown
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased PR on develop.

@vkarak vkarak enabled auto-merge May 19, 2026 20:39
@vkarak vkarak merged commit deb6107 into reframe-hpc:develop May 19, 2026
31 of 32 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in ReFrame Backlog May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants