Add code block integration coverage - #6520
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Greptile SummaryThe PR adds integration coverage for code-block rendering, wrapping, themes, line numbers, and copy buttons while improving reactive custom styles and preserving wrapping when code-tag properties are supplied.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| packages/reflex-components-code/src/reflex_components_code/code.py | Tracks reactive custom-style dependencies and merges pre-wrap styling into dictionary-based code-tag properties. |
| tests/integration/tests_playwright/test_code_block.py | Adds browser coverage for code rendering, themes, line numbers, wrapping, custom props, and clipboard controls. |
| tests/units/components/datadisplay/test_code.py | Adds unit coverage confirming that state dependencies embedded in custom styles are collected. |
| packages/reflex-components-code/news/6520.bugfix.md | Documents the custom-style reactivity and wrapping fixes. |
Reviews (5): Last reviewed commit: "Merge branch 'main' into issue-6484-code..." | Re-trigger Greptile
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 836335ec90
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
…ck-tests # Conflicts: # pyi_hashes.json
The one-shot locator.evaluate() span check raced PrismAsyncLight's async grammar load and consistently failed on CI runners; replace it with an auto-waiting expect. Add the reflex-components-code news fragment required by the changelog check.
Summary
Fixes #6484
Tests