Skip to content

Prevent toolbar renders from leaking after React SDK tests - #726

Merged
roncohen merged 1 commit into
mainfrom
fix/react-sdk-toolbar-test
Sep 11, 2026
Merged

Prevent toolbar renders from leaking after React SDK tests#726
roncohen merged 1 commit into
mainfrom
fix/react-sdk-toolbar-test

Conversation

@roncohen

@roncohen roncohen commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • stub showToolbarToggle across the React SDK test suite
  • prevent deferred Preact toolbar work from accessing jsdom globals after teardown
  • cover providers and directly-created/external clients that do not use the shared toolbar={false} test helper

Validation

  • yarn workspace @reflag/react-sdk test:types
  • yarn workspace @reflag/react-sdk exec vitest run --reporter=dot (65 tests passed)
  • React SDK suite passed five consecutive runs before rebasing onto current main

Copilot AI lite review requested due to automatic review settings September 11, 2026 12:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@roncohen
roncohen enabled auto-merge September 11, 2026 12:33
@roncohen
roncohen added this pull request to the merge queue Sep 11, 2026
Merged via the queue into main with commit 293fcd2 Sep 11, 2026
7 of 8 checks passed
@roncohen
roncohen deleted the fix/react-sdk-toolbar-test branch September 11, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants