Skip to content

Send flag evaluation diagnostics from Node and React SDKs - #724

Open
roncohen wants to merge 4 commits into
mainfrom
feat/send-evaluation-diagnostics
Open

Send flag evaluation diagnostics from Node and React SDKs#724
roncohen wants to merge 4 commits into
mainfrom
feat/send-evaluation-diagnostics

Conversation

@roncohen

@roncohen roncohen commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • include Node flag evaluator diagnostics as evalErrors on is-enabled and config check events
  • preserve diagnostics returned by the browser flags API and include them in browser/React check events
  • retain deprecated evalMissingFields transport for compatibility
  • validate fetched browser diagnostics without adding new public error-type exports

Rollout

Do not release these SDK changes until reflagcom/web#3620 has been deployed so ingest accepts evalErrors.

Verification

  • Node SDK: 138 tests pass; TypeScript build passes
  • Browser SDK: 202 tests pass; TypeScript/Vite build passes
  • React SDK: 65 tests and type tests pass; build passes
  • lint and formatting pass
  • full monorepo build attempted; unrelated management SDK generation requires unavailable Java
  • post-change diff review found no actionable issues

Copilot AI lite review requested due to automatic review settings September 10, 2026 16:45
Copilot AI reviewed Sep 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings September 10, 2026 17:00
Copilot AI reviewed Sep 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings September 10, 2026 17:23
Copilot AI reviewed Sep 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings September 10, 2026 18:50
Copilot AI reviewed Sep 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roncohen