Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-pandas-refresh-opt-in.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@reflag/react-sdk": patch
---

Prevent `useOptInFlags()` from missing a flag update that finishes between render and event subscription.
1 change: 1 addition & 0 deletions packages/react-sdk/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -753,6 +753,7 @@ export function useOptInFlags(
useOnEvent("optInFlagsLoadingUpdated", setIsOptInFlagsLoading, client);

useIsomorphicLayoutEffect(() => {
setFlags(getOptInFlags());
setIsOptInFlagsLoading(client.getIsLoadingOptInFlags());
}, [client]);

Expand Down
61 changes: 61 additions & 0 deletions packages/react-sdk/test/usage.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1146,6 +1146,67 @@ describe("opt-in hooks", () => {
unmount();
});

test("does not miss opt-in flags updated between render and subscription", async () => {
const client = new ReflagClient({
publishableKey: "key-opt-in-mount-race",
offline: true,
});
const optInFlag = {
key: "optInFlag",
name: "Opt-in flag",
description: null,
isEnabled: false,
userOptedIn: false,
companyOptedIn: false,
isOptedIn: false,
};
const getOptInFlags = vi
.spyOn(client, "getOptInFlags")
.mockReturnValueOnce([])
.mockReturnValue([optInFlag]);

const { result, unmount } = renderHook(() => useOptInFlags(), {
wrapper: ({ children }) => (
<ReflagClientProvider client={client} initialLoading={false}>
{children}
</ReflagClientProvider>
),
});

expect(result.current).toEqual({ flags: [optInFlag], isLoading: false });
expect(getOptInFlags).toHaveBeenCalledTimes(2);

unmount();
await client.stop();
});

test("returns an empty flags array when regular provider initialization fails", async () => {
const logger = {
debug: vi.fn(),
info: vi.fn(),
warn: vi.fn(),
error: vi.fn(),
};
const initialize = vi
.spyOn(ReflagClient.prototype, "initialize")
.mockRejectedValueOnce(new Error("init failed"));

const { result, unmount } = renderHook(() => useOptInFlags(), {
wrapper: ({ children }) => getProvider({ children, logger }),
});

await waitFor(() => {
expect(logger.error).toHaveBeenCalledWith(
"failed to initialize client",
expect.any(Error),
);
});
expect(result.current).toEqual({ flags: [], isLoading: false });

unmount();
initialize.mockRestore();
});

test("suspends with a regular provider during the initial flags request", async () => {
let resolveResponse!: (response: HttpResponse) => void;
const response = new Promise<HttpResponse>((resolve) => {
Expand Down
Loading