Print output in json format when using global --json flag#274
Draft
vbmade2000 wants to merge 3 commits into
Draft
Print output in json format when using global --json flag#274vbmade2000 wants to merge 3 commits into
vbmade2000 wants to merge 3 commits into
Conversation
Signed-off-by: Malhar Vora <mlvora.2010@gmail.com>
Contributor
Author
|
@atimin The PR is still in WIP. Let me know your thoughts on approach taken in this PR. |
atimin
reviewed
Jul 22, 2026
| // Do not output json if the command is "cp" | ||
| if matches.get_flag("json") && command != "cp" { | ||
| let json_error = json!({ | ||
| "status": "error", |
Member
There was a problem hiding this comment.
reduct-rs sdk returns the ReductError with a status and an error message. I think we can attach it to the anyhow error and downcast here to get the status. See https://docs.rs/anyhow/latest/anyhow/trait.Context.html.
Contributor
Author
There was a problem hiding this comment.
Ah I didn't know that ReductError error has status code too. I'll update the code.
Member
|
Hi @vbmade2000 , I think it's a good approach but we could try to improve the error handling without breaking the interfaces. |
Signed-off-by: Malhar Vora <mlvora.2010@gmail.com>
Contributor
Author
|
@atimin I have updated code to return status code. |
Signed-off-by: Malhar Vora <mlvora.2010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #254
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
What was changed?
(Describe the changes)
Related issues
(Add links to related issues)
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Other information: