docs(skills): improve implement-command guidance#3353
Merged
Conversation
Add recurring guidance to the implement-command skill: - Ask up front for a live server with the command; probe every branch - Ask for the first server version that ships the command - Gate behavior tests with minimumDockerVersion on client + cluster - Add @SInCE to the registry JSDoc - Explain RESP2/RESP3 unification: RESP3 is the target shape, RESP2 is transformed to match it (HELLO.ts / HGETALL.ts as references) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds recurring guidance to the
implement-commandskill that kept coming up when wiring new Redis commands:sincefield, else ask).minimumDockerVersion: [major, minor]into bothclientandclusterso behavior tests don't run (and fail) on older servers in CI. Arg tests stay ungated.@sinceJSDoc — registry entries get@since <version>.3:pass-through,2:reshape). ReferencesHELLO.tsandHGETALL.ts.Checklist items updated to match.
🤖 Generated with Claude Code
Note
Low Risk
Documentation-only change to an agent skill file; no production code, tests, or CI behavior is modified.
Overview
Updates
.agents/skills/implement-command/SKILL.mdso agents follow a tighter workflow when adding Redis commands—no runtime or test code changes.Step 0 now requires three upfront inputs (spec, live Redis with the command, and the introducing server/module version), with stronger emphasis on probing real replies instead of trusting the spec alone.
New guidance covers RESP2/RESP3: callers see one type—the RESP3 shape—with
3:usually pass-through and2:reshaping (e.g.HELLO.ts), plus verification over both protocols on the live instance.Registry JSDoc should include
@sincefrom the spec’ssincefield, and behavior tests should setminimumDockerVersionon bothclientandcluster(arg/parseArgstests stay ungated). The completion checklist and spec-mapping table are aligned with these rules.Reviewed by Cursor Bugbot for commit 70749dd. Bugbot is set up for automated code reviews on this repo. Configure here.