refactor(test-utils): single source for default docker test image config#3349
Merged
Merged
Conversation
Every package's test-utils duplicated the same createFromConfig block (image name, CLI argument names, default tag/version). Move it into @redis/test-utils as DEFAULT_DOCKER_CONFIG with a createDefault() factory, so bumping the default test image now touches one file instead of eight. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The default docker image config now lives only in DEFAULT_DOCKER_CONFIG in @redis/test-utils, so the skill edits one file instead of eight. Also add an explicit commit message template so bump commits stay consistent, and accept tags given in the full image:tag form. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
nkaradzhov
force-pushed
the
dedupe-test-image-config
branch
from
July 21, 2026 18:47
87afd56 to
385c054
Compare
PavelPashov
approved these changes
Jul 22, 2026
| ## Step 7 — Force-push and PR | ||
|
|
||
| ```bash | ||
| git push -f origin bump-test-image |
Contributor
There was a problem hiding this comment.
Could we derive the branch name from the image tag (for example, bump-test-image/<tag>), fetch that remote branch when it exists, and use git push --force-with-lease? This keeps separate image bumps isolated while safely supporting reruns for the same tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every package's test-utils duplicated the same
createFromConfigblock (image name, CLI argument names, default tag/version), so bumping the default test image meant touching eight files.This moves the shared config into
@redis/test-utilsas an exportedDEFAULT_DOCKER_CONFIGwith aTestUtils.createDefault()factory, and switches all eight call sites to it. Future bumps touch one line in one file (plus the CI matrix).Also updates the
bump-test-imageagent skill to match the new layout and adds a commit message template to it for consistent bump commits.🤖 Generated with Claude Code