Add async Python SDK client (AsyncAFS) over httpx - #21
Merged
Merged
Conversation
True-async port of the sync SDK on httpx.AsyncClient, shipped as the optional redis-afs[async] extra so the core stays zero-dependency. Mirrors the sync public API; adds a MountMode enum and bounded-concurrency file sync. 39 tests; README + api-docs updated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
rowantrollope
marked this pull request as ready for review
June 17, 2026 16:25
Collaborator
|
Thanks for the contribution Zecheng! Accepted the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a true-async client to the Python SDK (
AsyncAFSand friends), mirroring the existing sync SDK and the TypeScript SDK's async shape. The sync SDK blocks onurllib.request.urlopen, which stalls the event loop inside async servers (FastAPI etc.); the async clientawaits its I/O instead and fans out file sync concurrently.httpx.AsyncClient, shipped as the optionalredis-afs[async]extra — the core install stays zero-dependency and imports fine without httpx (constructing an async client without it raises a clear error).from redis_afs import AsyncAFS.MountModeenum (mirrors the control plane'sworkspace-*profiles); bounded-concurrency file sync; bash viacreate_subprocess_execwith kill+reap on timeout.[async]extra.Test plan
cd sdk/python && pip install -e '.[async]'PYTHONPATH=src python3 -m unittest discover -s tests(39 passing)🤖 Generated with Claude Code