#5543 Fix home database table scrolling#6124
Conversation
|
|
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e563987b6e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onPaginationChange={handlePaginationChange} | ||
| defaultSorting={DEFAULT_SORTING} | ||
| maxHeight="60rem" // this enables vertical scroll | ||
| style={{ maxHeight: '100%' }} |
There was a problem hiding this comment.
When the Home list is taller than the available viewport, this no longer uses the Redis UI Table maxHeight prop that creates/sizes the table's internal scroll area; it only applies a plain CSS max-height to the outer component. Since this commit also changes .homePage to overflow: hidden, rows beyond the available height can be clipped instead of scrollable. Keep the height constraint on the table API, e.g. maxHeight="100%", rather than moving it into style.
Useful? React with 👍 / 👎.
2 participants
What
Fixes the Redis Databases table on the Home screen so users can scroll through the full database list.
The table previously used a fixed
maxHeight="60rem"value, which could overflow the available page area and cause lower rows to be clipped on smaller screens. This change lets the table use the available Home page height and keeps vertical overflow inside the table viewport.The Home page layout was also adjusted so the page body and database list container can shrink correctly within the available viewport height. This allows the Redis UI table’s internal scroller to handle long database lists instead of the page clipping the table content.
Closes #5543
Note
Low Risk
Home-page layout and table height styling only; no auth, data, or API changes.
Overview
Fixes clipped rows on the Home Redis Databases table by sizing the table to the available page height instead of a fixed 60rem cap.
DatabasesListpassesstyle={{ maxHeight: '100%' }}to the sharedTableso height follows its flex parent rather than overflowing on shorter viewports.Home layout CSS adds
min-height: 0on.RI-page-bodyand switches.homePagefromheight: calc(100% - 60px)with page-leveloverflow-y: autoto a flex child (flex: 1 1 auto,min-height: 0,overflow: hidden) so the list area shrinks within the viewport and the table’s internal scroller owns vertical overflow.Reviewed by Cursor Bugbot for commit e563987. Bugbot is set up for automated code reviews on this repo. Configure here.