Drop explicit Microsoft.SourceLink.GitHub reference - #565
Merged
Merged
Conversation
The .NET SDK has included and enabled Source Link for GitHub-hosted repos by default since 8.0.100; our pinned SDK (10.0.101+, rollForward latestMajor) is well past that. Referencing the package explicitly overrides the SDK's own bundled version, taking on a dependency and its future CVE/version churn for nothing. Verified the generated *.sourcelink.json and packed nuspec <repository> element are unchanged across all target frameworks (net481, netstandard2.0, net6.0/8.0/10.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .NET SDK has included and enabled Source Link for GitHub-hosted repos by default since 8.0.100; our pinned SDK (10.0.101+, rollForward latestMajor) is well past that. Referencing the package explicitly overrides the SDK's own bundled version, taking on a dependency and its future CVE/version churn for nothing.
Verified the generated *.sourcelink.json and packed nuspec element are unchanged across all target frameworks (net481, netstandard2.0, net6.0/8.0/10.0).
Note
Low Risk
Build/packaging-only dependency cleanup; expected to leave Source Link artifacts unchanged per PR verification.
Overview
Removes the explicit Microsoft.SourceLink.GitHub package from central package management and the repo-wide
Directory.Build.propsreference so builds rely on the .NET SDK’s built-in GitHub Source Link instead of pinning a separate package version.This avoids overriding the SDK’s bundled Source Link (relevant for SDK 8.0.100+ / the repo’s current SDK line) and drops an extra dependency with no intended change to sourcelink output or nuspec repository metadata.
Reviewed by Cursor Bugbot for commit 7225c50. Bugbot is set up for automated code reviews on this repo. Configure here.