CI fixes for preview image - CMS.INFO and FT.SEARCH TIMEOUT - #554
Merged
Merged
Conversation
2. for FT.SEARCH timeout queries, increase count by order-of-magnitude to reliably force fault
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5166ff2ae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Backward-compatible response parsing plus a test fixture size change; no auth or production behavior changes beyond exposing a new read-only CMS property.
Overview
Adds support for the newer Redis CMS.INFO field
cell size:CmsInformationexposesCellSize(defaults to -1 when the server omits it),ToCmsInfomaps the"cell size"label, and the public API surface is updated accordingly.For FT.SEARCH / FT.AGGREGATE on-timeout integration tests,
TimeoutDocCountinSearchTestsis raised from 10,000 to 100,000 so a 1ms timeout still reliably triggers the engine’s on-timeout behavior on faster preview CI images.Reviewed by Cursor Bugbot for commit a5166ff. Bugbot is set up for automated code reviews on this repo. Configure here.