-
Notifications
You must be signed in to change notification settings - Fork 59
Bump xunit.v3 from 3.2.2 to 4.0.0 #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete xUnit runner upgrade
High Severity
This bump moves
xunit.v3to4.0.0while leavingxunit.runner.visualstudioat3.1.5andxunit.v3.runner.consoleat3.0.0. The official Visual Studio adapter4.0.0was released to support framework4.0.0and its updated configuration schema. CI and Test Explorer go through that adapter, and this repo depends onxunit.runner.jsondisabling parallel collections because tests callFLUSHALLagainst shared Redis. An unmatched major bump risks discovery/execution failures or ignored parallelization settings, plus breakage in the customTheoryDiscoverer/XunitTestCasesubclasses that 4.0 explicitly reworks.Reviewed by Cursor Bugbot for commit ff20898. Configure here.