Fix scale workload retry stage name showing base workload instead of …#1234
Fix scale workload retry stage name showing base workload instead of …#1234ebattat wants to merge 1 commit into
Conversation
…full name On retry, workload_name was re-read from the already-mutated workload variable (set to the base name by `workload = WORKLOAD` on first attempt), causing the Jenkins stage to display e.g. `winfio_vm` instead of `winfio_vm_scale`. Capture originalWorkload before the retry loop so the stage name is always the full workload name across all retry attempts. Affects: winfio_vm_scale, windows_vm_scale_*, vdbench_*_scale, fio_*_scale, bootstorm_vm_scale Assisted-by: Claude Code
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pipeline's per-workload retry loop now preserves the initial workload identifier in a dedicated variable and uses that for consistent stage naming, preventing the stage name from changing if the workload variable is reassigned during retry iterations (such as during scale handling). ChangesWorkload State Preservation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arpsharm, ebattat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
On retry, workload_name was re-read from the already-mutated workload variable (set to the base name by
workload = WORKLOADon first attempt), causing the Jenkins stage to display e.g.winfio_vminstead ofwinfio_vm_scale.Capture originalWorkload before the retry loop so the stage name is always the full workload name across all retry attempts.
Affects: winfio_vm_scale, windows_vm_scale_, vdbench_scale, fio*_scale, bootstorm_vm_scale
Assisted-by: Claude Code
Type of change
Note: Fill x in []
Description
For security reasons, all pull requests need to be approved first before running any automated CI
Summary by CodeRabbit