Skip to content

Fix scale workload retry stage name showing base workload instead of …#1234

Open
ebattat wants to merge 1 commit into
mainfrom
fix/scale-retry-stage-name
Open

Fix scale workload retry stage name showing base workload instead of …#1234
ebattat wants to merge 1 commit into
mainfrom
fix/scale-retry-stage-name

Conversation

@ebattat
Copy link
Copy Markdown
Member

@ebattat ebattat commented May 31, 2026

On retry, workload_name was re-read from the already-mutated workload variable (set to the base name by workload = WORKLOAD on first attempt), causing the Jenkins stage to display e.g. winfio_vm instead of winfio_vm_scale.

Capture originalWorkload before the retry loop so the stage name is always the full workload name across all retry attempts.

Affects: winfio_vm_scale, windows_vm_scale_, vdbench_scale, fio*_scale, bootstorm_vm_scale

Assisted-by: Claude Code

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

For security reasons, all pull requests need to be approved first before running any automated CI

Summary by CodeRabbit

  • Bug Fixes
    • Fixed workload name inconsistency during retry operations in the deployment pipeline, ensuring stable identification across retry attempts.

…full name

On retry, workload_name was re-read from the already-mutated workload variable
(set to the base name by `workload = WORKLOAD` on first attempt), causing the
Jenkins stage to display e.g. `winfio_vm` instead of `winfio_vm_scale`.

Capture originalWorkload before the retry loop so the stage name is always
the full workload name across all retry attempts.

Affects: winfio_vm_scale, windows_vm_scale_*, vdbench_*_scale, fio_*_scale, bootstorm_vm_scale

Assisted-by: Claude Code
@ebattat ebattat requested a review from arpsharm May 31, 2026 07:49
@ebattat ebattat self-assigned this May 31, 2026
@ebattat ebattat added the bug Something isn't working label May 31, 2026
@github-project-automation github-project-automation Bot moved this to In progress in benchmark-runner May 31, 2026
@openshift-ci openshift-ci Bot requested a review from RobertKrawitz May 31, 2026 07:49
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 692f50e8-4f59-47ce-b0a6-33a41c422efc

📥 Commits

Reviewing files that changed from the base of the PR and between eb32ea0 and 2ac8de4.

📒 Files selected for processing (1)
  • jenkins/PerfCI/03_PerfCI_Workloads_Deployment/Jenkinsfile

📝 Walkthrough

Walkthrough

The pipeline's per-workload retry loop now preserves the initial workload identifier in a dedicated variable and uses that for consistent stage naming, preventing the stage name from changing if the workload variable is reassigned during retry iterations (such as during scale handling).

Changes

Workload State Preservation

Layer / File(s) Summary
Workload state capture in retry loop
jenkins/PerfCI/03_PerfCI_Workloads_Deployment/Jenkinsfile
Initial workload value is captured in originalWorkload before the retry try block. The stage's workload_name is set from originalWorkload instead of the workload variable, which may be reassigned later during scale handling, ensuring consistent stage naming across retries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • arpsharm
  • RobertKrawitz
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main fix: preventing scale workload retry stage names from showing the base workload instead of the full scaled workload name.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/scale-retry-stage-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arpsharm, ebattat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved bug Something isn't working lgtm

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants