docs(help-wanted): #182 solved the next-uses-bare-name kit, but the docs still counted it as open - #202
Conversation
…ocs still counted it as open @antoleod's #182 fixed the problem the next-uses-bare-name starter kit describes. prompts/help-wanted/README.md still listed it as open, and README.md said "twenty open problems", "twenty kits", "all twenty prompts" and "(three)" good first issues. Each of those counts is kept by hand and goes stale whenever a kit is solved. - prompts/help-wanted/README.md: the kit's row moves to a new Solved table at the end, which names #182, its author and the issue it closed (#158). - prompts/help-wanted/next-uses-bare-name.md: kept as a worked example of a kit that landed. A note at the top says the paths, lines and outputs below describe the tree before the fix. - README.md: the four counts are reworded without a number. No generated document and no gate pins these counts. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…fuses Section 7 of the reference guide said "A missing index causes a refusal." Since #197 a --scip path that is empty, or is not a regular file (a directory, a FIFO, a device), is refused the same way (exit 1). The sentence now says so, in the guide's own one-instruction-per-sentence style, matching the escalation list #197 already updated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe README updates contribution links and SCIP input validation guidance. The help-wanted documentation moves ChangesDocumentation and guidance
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The documentation updates are consistent and do not introduce a merge-blocking behavior change. 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: Out of Scope Changes checkExplanation The solved-kit documentation, solved table entry, and stale open-problem count are within
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
@antoleod's #182 fixed the problem the
next-uses-bare-namestarter kit describes, and with it #158. The docs still count that kit as open:prompts/help-wanted/README.mdlists it among the open problems.README.mdsays "twenty open problems", "twenty kits — pick one" and "all twenty prompts", and shows "(three)" beside the good-first-issue label.Change
prompts/help-wanted/README.md: the kit's row moves to a new Solved table at the end of the file. The table names Fix declined next-pointer callers #182, its author and the issue it closed.prompts/help-wanted/next-uses-bare-name.md: the kit stays, as a worked example of one that landed. A note at the top says the paths, lines and outputs below describe the tree before the fix.README.md: the four counts are reworded without a number: "open problems", "pick one", "all the prompts", and the label link on its own. Each count was kept by hand and went stale every time a kit was solved, and getting kits solved is the point of the folder.No generated document and no gate pins these counts.
Also: the reference guide's
--scipsentenceSection 7 of the reference guide (#192) says "A missing index causes a refusal." Since #197, a
--scippath that is empty or is not a regular file (a directory, a FIFO or a device) is refused the same way, with exit 1. The sentence now says so, in the guide's own style. It matches the README's escalation list, which #197 already updated.Verification
On the merged tree: the 27 README gates plus
showcasecapturecheck,gates=28 pass=28 skip=0 fail=0.docs/limits_build.py --checkanddocs/gatecount_build.py --checkexit 0.Closes #158.
🤖 Generated with Claude Code