Skip to content

Allow schema to still validate even if AJV fails #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datho7561 merged 1 commit into from
Jun 5, 2026
Merged

Allow schema to still validate even if AJV fails #1269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/languageservice/services/yamlSchemaService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,15 @@ export class YAMLSchemaService extends JSONSchemaService {
toValidate = _cloneSchema(node, new Map(), stopAtDialectBoundary) as JSONSchema;
}

if (!validator(toValidate)) {
let valid = false;
try {
valid = validator(toValidate);
} catch (e) {
// AJV overflows on recursive/cyclic schemas; attempt to degrade gracefully
console.warn(l10n.t("Schema '{0}' could not be fully validated: {1}", loc, e.message));

@datho7561 datho7561 Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to report this as a warning or error on the text document and provide translations for this message, but I think this is good for now.

return;
}
if (!valid) {
localizeAjvErrors(validator.errors, ajvErrorLocale);
const errs: string[] = [];
for (const err of validator.errors as DefinedError[]) {
Expand Down
Loading