Skip to content
This repository was archived by the owner on May 11, 2022. It is now read-only.

Encountered issue with editor view#645

Merged
bfitzpat merged 1 commit into
redhat-developer:masterfrom
pwright:patch-5
Jul 14, 2021
Merged

Encountered issue with editor view#645
bfitzpat merged 1 commit into
redhat-developer:masterfrom
pwright:patch-5

Conversation

@pwright

@pwright pwright commented Jul 13, 2021

Copy link
Copy Markdown
Contributor

I believe this issue was caused by my exercising new feature at https://code.visualstudio.com/updates/v1_58#_terminals-in-the-editor-area
Altho I had to mess around to get things going, so not 100% sure

I believe this issue was caused by my exercising new feature at https://code.visualstudio.com/updates/v1_58#_terminals-in-the-editor-area
Altho I had to mess around to get things going, so not 100% sure
@bfitzpat

Copy link
Copy Markdown
Collaborator

Very interesting. We have some issues with supporting 1.58.x as a version right now anyway - #639 doesn't build due to some weird changes upstream.

Thanks for sharing this and we'll definitely keep it for when we update!

@bfitzpat bfitzpat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a +1

@bfitzpat

Copy link
Copy Markdown
Collaborator

So @pwright just to confirm... this is when running Didact (which is built against 1.57.x) on a vscode instance that's 1.58.x?

@pwright

pwright commented Jul 13, 2021

Copy link
Copy Markdown
Contributor Author

@bfitzpat yes that's correct

@bfitzpat bfitzpat merged commit 419c52c into redhat-developer:master Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants