feat: Gangway override flags, commission-release workflow, PR #25 follow-ups#38
Open
zdrapela wants to merge 7 commits into
Open
Conversation
…dex, chart version, playwright version Add --catalog-index-image (both repos), --chart-version (RHDH-only), and --playwright-version (overlay-only) flags to trigger_nightly_job.py. Restructure argument groups into shared, RHDH-only, and overlay-only with per-repo validation that rejects unsupported flags. Update SKILL.md with new options, RC/GA verification examples, and updated flag reference. Jira: https://redhat.atlassian.net/browse/RHIDP-14348 Assisted-by: OpenCode
…h config Add references/release-branch-config.md with shared definitions (file paths, branch protection template, release-vs-main differences) used by both commission and decommission workflows. Add workflows/commission-release.md for bootstrapping CI configuration when a new RHDH release branch is created. Refactor workflows/decommission-release.md to reference the shared config and use 'make update' for generated job cleanup instead of manual file deletion. Update SKILL.md description and routing table. Assisted-by: OpenCode
Replace .replace(' ', '+') with urllib.parse.quote_plus() for proper
URL encoding of product names in the fallback _fetch_api function.
Guard api_data.get('data', [{}])[0] against empty data arrays to
prevent IndexError when the API returns no results.
Addresses non-blocking review items from PR redhat-developer#25.
Assisted-by: OpenCode
Validate that --reference matches X.Y format before splitting, matching
the existing validation in generate_test_entry.py. Previously, a
malformed --reference value would crash at split('.').
Addresses non-blocking review item from PR redhat-developer#25.
Assisted-by: OpenCode
Document that prow skill scripts use ruamel.yaml via PEP 723 inline script metadata for round-trip YAML fidelity. The dependency is managed by uv run --script with no user-facing install step. Addresses non-blocking review item from PR redhat-developer#25. Assisted-by: OpenCode
Add Platform Lifecycle and CI / Prow sections covering the three skills added via PRs redhat-developer#25 and redhat-developer#26 that were missing from the README. Assisted-by: OpenCode
- Bump version 0.3.1 → 0.3.2 (pyproject.toml, plugin.json, marketplace.json)
- Add Slack alert setup section to release-branch-config.md (channel
creation, incoming webhook, Vault secret configuration)
- Add Slack setup step to commission-release.md workflow
- Standardize placeholder casing to {version} in release-branch-config.md
- Clarify releases.latest.release field description
- Extract _first_versions() helper in analyze_coverage.py to DRY up
the repeated api_data.get('data', [])[0] pattern
- Clarify decommission-release.md: generated jobs removed by make update
- Decommission workflow now runs make update — the previous 'Do NOT run
make update' guidance was incorrect; make update correctly removes
generated job files for deleted configs, matching commission behavior
Assisted-by: OpenCode
zdrapela
force-pushed
the
feature/gangway-overrides-commission-release
branch
from
e7f9e30 to
1d868ea
Compare
Member
Author
|
@durandom This PR is ready for a review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--catalog-index-image,--chart-version(RHDH-only),--playwright-version(overlay-only) flags with per-repo validationrelease-branch-config.mdreference; refactor decommission to use shared ref +make updateanalyze_coverage.pyURL encoding and IndexError guard--referenceX.Y format validation togenerate_cluster_pool.pyJira: https://redhat.atlassian.net/browse/RHIDP-14348
Related PRs:
This PR is also addressing feedback from #25