feat: add code review pipeline to rhdh-pr-review skill (v0.3.1)#37
Merged
Conversation
Consolidate the personal pr-review-github skill into rhdh-pr-review with a layered architecture: fetch (forge-specific) -> analyze (agnostic) -> post (forge-specific), alongside existing cluster testing. New files: - workflows/fetch-github.md: GitHub PR context fetching - workflows/review-code.md: platform-agnostic code analysis - workflows/post-to-github.md: GitHub inline review posting - references/review-perspectives.md: review perspective examples - scripts/fetch_pr_context.py: stdlib-only fetch script The analyze layer is forge-agnostic — adding GitLab support later requires only fetch-gitlab.md and post-to-gitlab.md with no changes to the analysis workflow. Updated cross-references in rhdh orchestrator and README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the personal
pr-review-githubskill intorhdh-pr-reviewwith a layered, forge-pluggable architecture.Architecture
Three layers, each with a single job:
The analyze layer never calls forge-specific CLIs (except reading file contents at HEAD). Adding GitLab support later requires only
fetch-gitlab.md+post-to-gitlab.md— no changes to the analysis workflow.New files
scripts/fetch_pr_context.pyworkflows/fetch-github.mdworkflows/review-code.mdworkflows/post-to-github.mdgh apireferences/review-perspectives.mdModified files
SKILL.mdworkflows/review-operator-pr.mdskills/rhdh/SKILL.mdREADME.mdDesign decisions
review-code.md,post-to-github.mddoes a brief confirm onlyReview process
skill-reviewersubagent — fixed all 4 medium issues, 4 low issues, applied 2 suggestions