Skip to content

[release-1.8] fix(orchestrator-infra): increase infra-test pod memory to fix nightly CI#420

Merged
rm3l merged 1 commit into
redhat-developer:release-1.8from
rm3l:fix/release-1.8-infra-test-resources
May 29, 2026
Merged

[release-1.8] fix(orchestrator-infra): increase infra-test pod memory to fix nightly CI#420
rm3l merged 1 commit into
redhat-developer:release-1.8from
rm3l:fix/release-1.8-infra-test-resources

Conversation

@rm3l
Copy link
Copy Markdown
Member

@rm3l rm3l commented May 29, 2026

Description of the change

Increase infra-test pod memory requests and limits from 20Mi to 50Mi
(cherry-picked from 0afb7da on main) to fix nightly CI failures on release-1.8,
and bump the orchestrator-infra chart version to 0.2.4.

Which issue(s) does this PR fix or relate to

How to test changes / Special notes to the reviewer

Run the nightly orchestrator-infra tests on release-1.8 and verify the infra-test pod
no longer gets OOMKilled.

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file.

… to fix nightly CI

Bump infra-test pod memory requests and limits from 20Mi to 50Mi
(cherry-picked from 0afb7da on `main`) and bump chart version to 0.2.4.
@openshift-ci openshift-ci Bot requested review from subhashkhileri and zdrapela May 29, 2026 22:00
@rhdh-qodo-merge
Copy link
Copy Markdown

rhdh-qodo-merge Bot commented May 29, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Advisory comments

1. Hardcoded test pod resources 🐞 Bug ⚙ Maintainability
Description
The infra-test Pod’s CPU/memory requests+limits are hardcoded in the template, so resource tuning
cannot be done via values overrides and requires a chart change for every adjustment (as in this
PR’s 20Mi→50Mi bump). This makes the chart harder to operate across clusters/CI environments with
different constraints.
Code

charts/orchestrator-infra/templates/tests/infra-test.yaml[R90-96]

Relevance

⭐ Low

PR #408 tweaked infra-test memory but kept resources hardcoded; no precedent exposing test resources
via values.

PR-#408

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The test pod’s resources are defined inline in the template, but the chart values only expose
tests.enabled and tests.image, so there is currently no supported way to override CPU/memory
without editing the chart.

charts/orchestrator-infra/templates/tests/infra-test.yaml[90-96]
charts/orchestrator-infra/values.yaml[37-41]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The Helm test pod resources are hardcoded in the template, which forces future resource tuning to go through chart changes/releases instead of simple values overrides.

## Issue Context
This PR increases memory from 20Mi to 50Mi to address OOMKills, which highlights that these settings may need further adjustment over time.

## Fix Focus Areas
- charts/orchestrator-infra/templates/tests/infra-test.yaml[90-96]
- charts/orchestrator-infra/values.yaml[37-41]
- charts/orchestrator-infra/values.schema.tmpl.json[118-133]

## Suggested fix
1. Add `tests.resources.requests.cpu`, `tests.resources.requests.memory`, `tests.resources.limits.cpu`, `tests.resources.limits.memory` to `values.yaml` with defaults matching the current template values (10m / 50Mi).
2. Update the test pod template to render resources from `.Values.tests.resources` (falling back to defaults if unset).
3. Update `values.schema.tmpl.json` accordingly and regenerate `values.schema.json` if that’s the repo’s workflow.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@sonarqubecloud
Copy link
Copy Markdown

@rhdh-qodo-merge
Copy link
Copy Markdown

Review Summary by Qodo

Increase infra-test pod memory to fix nightly CI

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Increase infra-test pod memory requests and limits from 20Mi to 50Mi
• Bump orchestrator-infra chart version to 0.2.4
• Fix nightly CI failures caused by OOMKilled infra-test pod
• Update chart documentation with new version number
Diagram
flowchart LR
  A["infra-test pod<br/>memory: 20Mi"] -- "increase to 50Mi" --> B["infra-test pod<br/>memory: 50Mi"]
  C["Chart version<br/>0.2.3"] -- "bump version" --> D["Chart version<br/>0.2.4"]
  B --> E["Fix OOMKilled<br/>nightly CI failures"]

Loading

Grey Divider

File Changes

1. charts/orchestrator-infra/Chart.yaml ⚙️ Configuration changes +1/-1

Bump orchestrator-infra chart version

• Bumped chart version from 0.2.3 to 0.2.4

charts/orchestrator-infra/Chart.yaml


2. charts/orchestrator-infra/README.md 📝 Documentation +2/-2

Update README with new chart version

• Updated version badge from 0.2.3 to 0.2.4
• Updated helm install command example with new chart version

charts/orchestrator-infra/README.md


3. charts/orchestrator-infra/templates/tests/infra-test.yaml 🐞 Bug fix +2/-2

Increase infra-test pod memory resources

• Increased oc-client container memory requests from 20Mi to 50Mi
• Increased oc-client container memory limits from 20Mi to 50Mi

charts/orchestrator-infra/templates/tests/infra-test.yaml


Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added documentation Improvements or additions to documentation enhancement New feature or request Bug fix labels May 29, 2026
@rm3l rm3l merged commit ebef464 into redhat-developer:release-1.8 May 29, 2026
5 of 6 checks passed
@rm3l rm3l deleted the fix/release-1.8-infra-test-resources branch May 29, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug fix documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant