Skip to content

[release-1.9] fix(orchestrator-infra): increase infra-test pod memory to fix nightly CI#419

Merged
rm3l merged 1 commit into
redhat-developer:release-1.9from
rm3l:fix/release-1.9-infra-test-resources
May 29, 2026
Merged

[release-1.9] fix(orchestrator-infra): increase infra-test pod memory to fix nightly CI#419
rm3l merged 1 commit into
redhat-developer:release-1.9from
rm3l:fix/release-1.9-infra-test-resources

Conversation

@rm3l
Copy link
Copy Markdown
Member

@rm3l rm3l commented May 29, 2026

Description of the change

Increase infra-test pod memory requests and limits from 20Mi to 50Mi
(cherry-picked from 0afb7da on main) to fix nightly CI failures on release-1.9,
and bump the orchestrator-infra chart version to 0.4.3.

Which issue(s) does this PR fix or relate to

How to test changes / Special notes to the reviewer

Run the nightly orchestrator-infra tests on release-1.9 and verify the infra-test pod
no longer gets OOMKilled.

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Run pre-commit run --all-files to run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

… to fix nightly CI

Bump infra-test pod memory requests and limits from 20Mi to 50Mi
(cherry-picked from 0afb7da) and bump chart version to 0.4.3.
@rhdh-qodo-merge
Copy link
Copy Markdown

rhdh-qodo-merge Bot commented May 29, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Remediation recommended

1. Hardcoded test resources 🐞 Bug ☼ Reliability
Description
The infra-test pod memory/CPU requests and limits are hardcoded in the template (now 50Mi), so users
cannot override them via values. This can cause helm test to fail to create the pod in namespaces
with ResourceQuota/LimitRange policies that require different resource values.
Code

charts/orchestrator-infra/templates/tests/infra-test.yaml[R90-96]

Relevance

⭐⭐ Medium

Team exposes config knobs (e.g., ttlSecondsAfterFinished in #407), but #408 kept test resources
hardcoded.

PR-#407
PR-#408

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The PR increases the test pod memory to 50Mi, but the resources remain hardcoded in the template and
there is no chart values/schema field to override them, so users cannot adapt the test pod resources
to cluster policies.

charts/orchestrator-infra/templates/tests/infra-test.yaml[90-97]
charts/orchestrator-infra/values.yaml[37-41]
charts/orchestrator-infra/values.schema.json[113-128]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The infra-test pod container resources are hardcoded in the Helm template, so after raising memory to 50Mi users cannot adjust requests/limits for their cluster policies (LimitRange/ResourceQuota), leading to pod admission/scheduling failures during `helm test`.

## Issue Context
- The template sets fixed resources on the test pod container.
- The chart exposes `tests.enabled` and `tests.image`, but no `tests.resources`, and the schema does not allow configuring resources.

## Fix Focus Areas
- charts/orchestrator-infra/templates/tests/infra-test.yaml[90-96]
- charts/orchestrator-infra/values.yaml[37-41]
- charts/orchestrator-infra/values.schema.json[113-128]

## Suggested fix
1. Add `tests.resources` defaults in `values.yaml` (with the new 50Mi values as defaults).
2. Update `infra-test.yaml` to render `resources` from `.Values.tests.resources` (e.g., `toYaml` + `nindent`).
3. Extend `values.schema.json` to include `tests.resources` (requests/limits) so validation and docs generation stay aligned.
4. Regenerate README/values docs if required by the repo’s tooling (helm-docs/pre-commit).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@sonarqubecloud
Copy link
Copy Markdown

@rhdh-qodo-merge
Copy link
Copy Markdown

Review Summary by Qodo

Increase infra-test pod memory to fix nightly CI

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Increase infra-test pod memory requests and limits from 20Mi to 50Mi
• Resolves OOMKilled failures in nightly CI on release-1.9 branch
• Bump orchestrator-infra chart version to 0.4.3
• Update documentation to reflect new chart version
Diagram
flowchart LR
  A["infra-test Pod"] -->|"memory: 20Mi → 50Mi"| B["Resource Requests"]
  A -->|"memory: 20Mi → 50Mi"| C["Resource Limits"]
  D["Chart.yaml"] -->|"version: 0.4.2 → 0.4.3"| E["Chart Version"]
  F["README.md"] -->|"version: 0.4.2 → 0.4.3"| G["Documentation"]

Loading

Grey Divider

File Changes

1. charts/orchestrator-infra/Chart.yaml ⚙️ Configuration changes +1/-1

Update orchestrator-infra chart version

• Bump chart version from 0.4.2 to 0.4.3

charts/orchestrator-infra/Chart.yaml


2. charts/orchestrator-infra/README.md 📝 Documentation +2/-2

Update documentation with new chart version

• Update version badge from 0.4.2 to 0.4.3
• Update helm install command example to reference version 0.4.3

charts/orchestrator-infra/README.md


3. charts/orchestrator-infra/templates/tests/infra-test.yaml 🐞 Bug fix +2/-2

Increase infra-test pod memory resources

• Increase memory requests for oc-client container from 20Mi to 50Mi
• Increase memory limits for oc-client container from 20Mi to 50Mi
• Fixes OOMKilled errors in nightly CI tests

charts/orchestrator-infra/templates/tests/infra-test.yaml


Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added documentation Improvements or additions to documentation enhancement New feature or request bug_fix labels May 29, 2026
@rm3l rm3l merged commit dd2de7f into redhat-developer:release-1.9 May 29, 2026
5 of 6 checks passed
@rm3l rm3l deleted the fix/release-1.9-infra-test-resources branch May 29, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug_fix documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant