Skip to content

fix(orchestrator): make ttlSecondsAfterFinished optional to prevent GitOps reconciliation loops #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 3 commits into from
May 29, 2026
Merged

fix(orchestrator): make ttlSecondsAfterFinished optional to prevent GitOps reconciliation loops #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3121b12
fix(orchestrator): make ttlSecondsAfterFinished optional to prevent G…
rm3l May 29, 2026
323e8bd
fix(orchestrator): align dbCreationJob field titles in schema templat…
rm3l May 29, 2026
091a9b0
fix(orchestrator): remove arbitrary max on dbCreationJobBackoffLimit
rm3l May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/backstage/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ sources: []
# Versions are expected to follow Semantic Versioning (https://semver.org/)
# Note that when this chart is published to https://github.com/openshift-helm-charts/charts
# it will follow the RHDH versioning 1.y.z
version: 6.0.0
version: 6.0.1
10 changes: 5 additions & 5 deletions charts/backstage/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

# RHDH Backstage Helm Chart for OpenShift

![Version: 6.0.0](https://img.shields.io/badge/Version-6.0.0-informational?style=flat-square)
![Version: 6.0.1](https://img.shields.io/badge/Version-6.0.1-informational?style=flat-square)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A Helm chart for deploying Red Hat Developer Hub, which is a Red Hat supported version of Backstage.
Expand Down Expand Up @@ -29,7 +29,7 @@ For the **Generally Available** version of this chart, see:
helm repo add bitnami https://charts.bitnami.com/bitnami
helm repo add redhat-developer https://redhat-developer.github.io/rhdh-chart

helm install my-backstage redhat-developer/backstage --version 6.0.0
helm install my-backstage redhat-developer/backstage --version 6.0.1
```

## Introduction
Expand Down Expand Up @@ -211,9 +211,9 @@ Kubernetes: `>= 1.27.0-0`
| orchestrator.serverlessOperator.enabled | | bool | `true` |
| orchestrator.sonataflowPlatform.createDBJobImage | Image for the container used by the create-db job | string | `"{{ .Values.upstream.postgresql.image.registry }}/{{ .Values.upstream.postgresql.image.repository }}:{{ .Values.upstream.postgresql.image.tag }}"` |
| orchestrator.sonataflowPlatform.dataIndexImage | Image for the container used by the sonataflow data index, optional and used for disconnected environments | string | `""` |
| orchestrator.sonataflowPlatform.dbCreationJobActiveDeadlineSeconds | Maximum time in seconds for the create-db Job to complete before being terminated | int | `120` |
| orchestrator.sonataflowPlatform.dbCreationJobBackoffLimit | Number of retries for the create-db job if it fails | int | `2` |
| orchestrator.sonataflowPlatform.dbCreationJobTTLSecondsAfterFinished | Time in seconds after which a finished create-db Job is automatically deleted | int | `300` |
| orchestrator.sonataflowPlatform.dbCreationJobActiveDeadlineSeconds | Maximum time in seconds for the Sonataflow database creation Job to complete before being terminated | int | `120` |
| orchestrator.sonataflowPlatform.dbCreationJobBackoffLimit | Number of retries for the Sonataflow database creation job if it fails | int | `2` |
| orchestrator.sonataflowPlatform.dbCreationJobTTLSecondsAfterFinished | Time in seconds after which the Sonataflow database creation Job is automatically deleted. Leave empty to disable (recommended for GitOps/ArgoCD) | int | `nil` |
| orchestrator.sonataflowPlatform.eventing.broker.name | | string | `""` |
| orchestrator.sonataflowPlatform.eventing.broker.namespace | | string | `""` |
| orchestrator.sonataflowPlatform.externalDBHost | Host for the user-configured external Database | string | `""` |
Expand Down
4 changes: 3 additions & 1 deletion charts/backstage/templates/sonataflows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ metadata:
name: {{ .Release.Name }}-create-sf-db-{{ .Chart.Version | replace "." "-" }}
namespace: {{ .Release.Namespace }}
spec:
ttlSecondsAfterFinished: {{ .Values.orchestrator.sonataflowPlatform.dbCreationJobTTLSecondsAfterFinished }}
{{- with .Values.orchestrator.sonataflowPlatform.dbCreationJobTTLSecondsAfterFinished }}
ttlSecondsAfterFinished: {{ . }}
{{- end }}
activeDeadlineSeconds: {{ .Values.orchestrator.sonataflowPlatform.dbCreationJobActiveDeadlineSeconds }}
template:
spec:
Expand Down
15 changes: 8 additions & 7 deletions charts/backstage/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,21 +478,22 @@
"dbCreationJobActiveDeadlineSeconds": {
"default": 120,
"minimum": 1,
"title": "Maximum time in seconds for the create-db Job to complete before being terminated",
"title": "Maximum time in seconds for the Sonataflow database creation Job to complete before being terminated",
"type": "integer"
},
"dbCreationJobBackoffLimit": {
"default": 2,
"maximum": 10,
"minimum": 0,
"title": "Number of retries for the create-db job if it fails",
"title": "Number of retries for the Sonataflow database creation job if it fails",
"type": "integer"
},
"dbCreationJobTTLSecondsAfterFinished": {
"default": 300,
"minimum": 0,
"title": "Time in seconds after which a finished create-db Job is automatically deleted",
"type": "integer"
"minimum": 1,
"title": "Time in seconds after which the Sonataflow database creation Job is automatically deleted. Leave empty to disable (recommended for GitOps/ArgoCD)",
"type": [
"integer",
"null"
]
},
"eventing": {
"additionalProperties": false,
Expand Down
12 changes: 5 additions & 7 deletions charts/backstage/values.schema.tmpl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,21 +570,19 @@
},
"dbCreationJobBackoffLimit": {
"default": 2,
"maximum": 10,
"minimum": 0,
Comment thread
Fortune-Ndlovu marked this conversation as resolved.
"title": "Number of retries for the create-db job if it fails",
"title": "Number of retries for the Sonataflow database creation job if it fails",
"type": "integer"
},
"dbCreationJobTTLSecondsAfterFinished": {
"default": 300,
"minimum": 0,
"title": "Time in seconds after which a finished create-db Job is automatically deleted",
"type": "integer"
"minimum": 1,
Comment thread
Fortune-Ndlovu marked this conversation as resolved.
"title": "Time in seconds after which the Sonataflow database creation Job is automatically deleted. Leave empty to disable (recommended for GitOps/ArgoCD)",
"type": ["integer", "null"]
},
"dbCreationJobActiveDeadlineSeconds": {
"default": 120,
"minimum": 1,
"title": "Maximum time in seconds for the create-db Job to complete before being terminated",
"title": "Maximum time in seconds for the Sonataflow database creation Job to complete before being terminated",
"type": "integer"
},
"jobServiceImage": {
Expand Down
8 changes: 4 additions & 4 deletions charts/backstage/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,11 +533,11 @@ orchestrator:
initContainerImage: "{{ .Values.upstream.postgresql.image.registry }}/{{ .Values.upstream.postgresql.image.repository }}:{{ .Values.upstream.postgresql.image.tag }}"
# -- Image for the container used by the create-db job
createDBJobImage: "{{ .Values.upstream.postgresql.image.registry }}/{{ .Values.upstream.postgresql.image.repository }}:{{ .Values.upstream.postgresql.image.tag }}"
# -- Number of retries for the create-db job if it fails
# -- Number of retries for the Sonataflow database creation job if it fails
dbCreationJobBackoffLimit: 2
# -- Time in seconds after which a finished create-db Job is automatically deleted
dbCreationJobTTLSecondsAfterFinished: 300
# -- Maximum time in seconds for the create-db Job to complete before being terminated
# -- (int) Time in seconds after which the Sonataflow database creation Job is automatically deleted. Leave empty to disable (recommended for GitOps/ArgoCD)
dbCreationJobTTLSecondsAfterFinished:
# -- Maximum time in seconds for the Sonataflow database creation Job to complete before being terminated
dbCreationJobActiveDeadlineSeconds: 120
# -- Image for the container used by the sonataflow jobs service, optional and used for disconnected environments
jobServiceImage: ""
Expand Down
Loading