Upstream merge - #183
Open
Sandeep-BA wants to merge 21 commits into
Open
Conversation
Config-driven loaders confine every reflectively loaded class to the intended type (BaseTool, BaseToolset, BaseExampleProvider, or the caller's expectedType) before constructing it or reading a static field, so a non-intended type is never instantiated nor its static initializer run (type-confinement, not a sandbox). CompiledAgentLoader also gains source-dir confinement (adk.agents.confine-to-source-dir), keeping compiled agents within source-dir. Type confinement is on by default; source-dir confinement is off by default (with a warning) to avoid breaking existing setups, and will default on in a future release. PiperOrigin-RevId: 948941874
…to match python ADK PiperOrigin-RevId: 949268862
…sion/listEvents
FirestoreSessionService stores each session at /{root}/{userId}/sessions/{sessionId},
so the document is keyed only by (userId, sessionId). getSession, deleteSession, and
listEvents fetched the document by (userId, sessionId) and never checked the stored
appName against the requested one, so a caller could read, list the events of, or
delete another application's session for the same user by passing any appName.
listSessions already scopes by appName (whereEqualTo(APP_NAME_KEY, appName)).
Add the same appName check to getSession, deleteSession, and listEvents, treating a
mismatch as "session not found", and add unit tests covering the appName-mismatch
cases for all three methods.
PiperOrigin-RevId: 950790337
PiperOrigin-RevId: 950796013
PiperOrigin-RevId: 950807008
Prevents a NullPointerException in the google-genai library when an Agent is defined without a description. Includes a regression test.
…oserverparams PiperOrigin-RevId: 951989850
…me-scope PiperOrigin-RevId: 951989980
PiperOrigin-RevId: 952000291
…rces Ensure every Java source carries the canonical Apache 2.0 header from `java.header`, without changing existing copyright years (the year reflects when a file was created): - Add the header to files that were missing it, using each file's creation year. - Repair malformed headers: drop duplicated/garbled lines and convert `//`-style headers to the required `/* */` block form, preserving the year. PiperOrigin-RevId: 952623369
…nMemorySessionService `getSession` applied `afterTimestamp` only when `numRecentEvents` was unset, so the two `GetSessionConfig` filters could not be combined. Apply `numRecentEvents` first, then `afterTimestamp`, so both compose. Mirrors Python and Go, which already apply both. PiperOrigin-RevId: 952725154
…ertexAiSessionService `getSession` gated the server-side `timestamp>=` filter on `numRecentEvents` being absent, so the two `GetSessionConfig` filters could not be combined. Send the `afterTimestamp` filter whenever it is set and still trim to `numRecentEvents` client-side, so both compose. Mirrors the Go port, which already applies both. PiperOrigin-RevId: 952765675
…parallel stop requests
PiperOrigin-RevId: 953232777
…-user-id PiperOrigin-RevId: 953237232
PiperOrigin-RevId: 955201053
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
A clear and concise description of what the problem is.
Solution:
A clear and concise description of what you want to happen and why you choose
this solution.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed java test results.
Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context
Add any other context or screenshots about the feature request here.