S3 artifact service - #171
Merged
Sandeep-BA merged 3 commits intoJun 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the PostgresArtifactService to improve how artifacts are stored and referenced in S3. It introduces the ability to specify a custom base folder path for S3 uploads and changes the stored file URI format from s3:// to standard HTTPS URLs, making the artifacts directly accessible via web clients.
Changes
Added S3_BASE_PATH support: Introduced a new environment variable S3_BASE_PATH that allows artifacts to be stored inside a specific folder/prefix in the S3 bucket (e.g., artifacts/) rather than at the root of the bucket.
Updated buildObjectKey: Modified the key generation logic to safely prepend the S3_BASE_PATH (handling trailing slashes) if it is configured.
Switched to HTTPS URLs: Updated persistToS3AndKafka to construct and store standard AWS S3 HTTPS URLs (https://{bucket}.s3.{region}.amazonaws.com/{key}) in the database's file_uri column instead of the s3:// protocol format.
Global endpoint fallback: Added a fallback to the global S3 endpoint (https://{bucket}.s3.amazonaws.com/{key}) if the S3_REGION environment variable is not set.
Gitignore update: Added contrib/samples/a2a_basic/bin/ to .gitignore.