fix(klx): fix qwen3.5-9B mm train/train_rollout_prob_abs_diff mismatch - #301
Open
grootZ wants to merge 1 commit into
Open
fix(klx): fix qwen3.5-9B mm train/train_rollout_prob_abs_diff mismatch#301grootZ wants to merge 1 commit into
grootZ wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XSGL_QUANT_ALL_GATHER默认配置取到1进而导致rollout prefill阶段做了低精量化通信，精度偏低，属于逻辑错误。目前暂时通过env规避，下一版本xSGL镜像会全面修复这个逻辑错误。目前修复后训推diff合理，rollout阶段耗时主要集中在decode，故耗时基本无影响，性能与之前相近
