Conversation
GitHub: red-data-toolsGH-5 This is a preparation for the `cache_path:` option that overrides the cache location. It does not change behavior.
GitHub: red-data-toolsGH-5 `cache_path:` overrides the cache location computed from the URL. The first entry is the cache ID and the rest is path in the cache: ```ruby RemoteInput.open("https://example.com/sample/data.csv", cache_path: "example/sub-directory/data.csv") do |input| # Cached at: # <system cache directory>/red-remote-input/example/sub-directory/data.csv end ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub: GH-5
cache_path:overrides the cache location computed from the URL. Thefirst entry is the cache ID and the rest is path in the cache:
cache_pathmust be<cache ID>/<path in cache>. The following pathsare raised with
ArgumentError:.or..data.csvcache_pathis used as is. Characters aren't replaced unlike the cacheID computed from the URL.
Extract the cache location logic into
RemoteInput::CacheEntryinpreparation. For internal use only.
I'll open a separated pull request not to change the real system cache
in tests.