feat: collapse the $0 release tail on the valuation card#42
feat: collapse the $0 release tail on the valuation card#42sweetmantech wants to merge 1 commit into
Conversation
Unmeasured releases rendered as a wall of "$0 · 0 streams" rows directly above the "Get the full report" CTA (18 rows for Del Water Gap), reading as failure at the conversion moment. Group them into one expandable row: "+N releases with no measurable streams". Measured releases keep their sorted display; the split is a pure, tested function. Part of recoupable/chat#1850. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Part of recoupable/chat#1850 ("Open — marketing polish"). Independent of the companion header-auth PR — the two can land in any order.
Problem
The "What we measured" list on the valuation card renders every release, including ones with zero measured streams. For a real artist (Del Water Gap) that put ~18 "$0 · 0 streams" rows directly above the "Get the full report with Recoup →" CTA — the last thing a lead scrolls past before converting reads as failure.
Change
lib/valuation/partitionMeasuredAlbums.ts— pure function splitting releases into measured (sorted biggest-first, as before) and the zero-stream tail. TDD: test written and confirmed RED before implementation.components/valuation/UnmeasuredReleasesRow.tsx— one collapsed row, "+N releases with no measurable streams" ("not counted in the estimate"), expandable via<details>to the release names + years, matching the existing row pattern.components/valuation/MeasuredCatalog.tsx— renders measured rows then the collapsed row; sorting moved into the pure function.Done-when check
$0rows — they all fall into the collapsed row.pnpm buildpasses (47 pages, no errors); full vitest suite 73/73 (6 new).Verification
🤖 Generated with Claude Code
Summary by cubic
Collapse zero‑stream releases on the valuation card into a single expandable row, keeping measured releases sorted by streams. This removes the wall of "$0 · 0 streams" rows above the CTA and makes the card read cleaner.
partitionMeasuredAlbumsto split measured vs zero‑stream releases and sort measured biggest‑first.UnmeasuredReleasesRowto show "+N releases with no measurable streams" (expandable to names and years, not counted in the estimate).MeasuredCatalogto render measured rows followed by the collapsed unmeasured row.Written for commit 41a2d0a. Summary will update on new commits.