CI: deflake Check Code Style by moving it to Depot - #167
Open
rjhuijsman wants to merge 1 commit into
Open
Conversation
Current Aviator status
This PR is queued for merge (review queue position). It will be merged when it reaches the top of the queue and all required status checks are passing. Pending Status Checks
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
rjhuijsman
changed the title
Check Code Style on a Depot runnerCheck Code Style
rjhuijsman
changed the title
Check Code StyleCheck Code Style by moving it to Depot
rjhuijsman
marked this pull request as ready for review
September 11, 2026 20:57
rjhuijsman
force-pushed
the
rjh.style-check-on-depot
branch
from
September 11, 2026 20:59
ad470ab to
2b1fdac
Compare
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
onelxj
approved these changes
Sep 12, 2026
aviator-app
Bot
force-pushed
the
rjh.style-check-on-depot
branch
from
September 12, 2026 05:46
2b1fdac to
25874bb
Compare
|
This pull request failed to merge: some required checks failed. After you have resolved the problem, you should remove the Failed checks: Test React Native mobile app (Maestro) / GitHub-hosted Runner |
The style checker builds the dev container before it can lint anything, so it pays the full container build cost. Before this change the job ran on a GitHub-hosted 4-core runner, the only job in the workflow still doing so - the 2025-05-22 change that onboarded our Depot runners moved the others over and left this one behind. Nothing documents a reason to keep it there: unlike the Maestro job, which needs `/dev/kvm` that Depot does not expose, the style checker has no GitHub-hosted-only requirement. That mattered because whenever a pull request changes a `Dockerfile` `ARG` above the first `FROM`, the build starts from scratch and re-downloads a few hundred packages. On the 4-core GitHub-hosted runners the `clang-20` layer's fetches from `apt.llvm.org` failed often - DNS returning an IPv6-only answer on a runner with no IPv6 route, or plain "Could not resolve 'apt.llvm.org'" partway through the downloads - and the style checker never ran at all. The job died that way on four consecutive runs on 2026-09-10 and 2026-09-11, for example run 34584281746. The same layer built cleanly every time on the Depot runners the sibling jobs already use, and in `copilot-setup-steps`. The job now runs on the same `depot-ubuntu-24.04-32` runner as the Linux x86_64 build, which also makes the container build itself several times faster. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0143bFU89gPnVXRJ1BQFgX1A
aviator-app
Bot
force-pushed
the
rjh.style-check-on-depot
branch
from
September 14, 2026 10:27
25874bb to
75d1b5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Check Code Stylejob was super flaky, due to an incompatibility between GitHub Actions runners andapt.llvm.org: the DNS server forapt.llvm.orgwill frequently insist on answering with an IPv6 address (and refuse if you ask it for only IPv4), and GitHub doesn't have IPv6 routes for its runners.This PR moves the
Check Code Stylejob over to the Depot runner (the last of our jobs to do so, everything is on Depot now). Depot has no issue talking IPv6 when needed.