Repository navigation
Reject palette PNGs without PLTE and invisible URL characters; run tests in CI - #23
Merged
reason-machines[bot] merged 7 commits intoNov 12, 2026
Merged
Conversation
…atGPT ZIP check Co-authored-by: qa-runner2-star <319404260+qa-runner2-star@users.noreply.github.com>
Co-authored-by: qa-runner2-star <319404260+qa-runner2-star@users.noreply.github.com>
Co-authored-by: qa-runner2-star <319404260+qa-runner2-star@users.noreply.github.com>
Address independent review of #22: reject credential-bearing, non-https, hostless or over-long listing URLs and empty listing text; fully parse icon PNGs (CRCs, IEND, complete image data, 48-4096 px); refuse symlinks in the package. Narrow the checkout audit claim to the name-only check, and distinguish Claude Team (Owner only) from Enterprise (Owner or custom role). Co-authored-by: qa-runner2-star <319404260+qa-runner2-star@users.noreply.github.com>
Reject incomplete or extra raster data, malformed PNG structure, invalid URL ports and whitespace, unpackaged icon paths and invalid review objects. Keep review cases omitted and clarify that historical case recovery is not required for a preserving update. Co-authored-by: qa-runner2-star <319404260+qa-runner2-star@users.noreply.github.com>
Exit with one actionable line instead of a traceback, cover the missing dependency in an isolated subprocess, and document requirements installation from a fresh virtual environment. Co-authored-by: qa-runner2-star <319404260+qa-runner2-star@users.noreply.github.com>
…8b70d7da' into reason/reason-plugins-directory-8b70d7da Co-authored-by: qa-runner2-star <319404260+qa-runner2-star@users.noreply.github.com> # Conflicts: # scripts/build_chatgpt_zip.py # tests/test_chatgpt_package.py Co-authored-by: qa-runner2-star <319404260+qa-runner2-star@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22 (merged as fecf24a) for the three non-blocking notes from the cross-provider review. No other scope: the manifest, logos, docs and saved review cases are unchanged, and
review.test_casesis still omitted. No portal actions.The branch carries #22's pre-squash commits through a merge commit, because the branch name is reused. Their tree is identical to fecf24a, so they add no file changes; the diff against main is only the three files below.
What changed
check_png_stream): a colour-type-3 PNG without a PLTE chunk, or with PLTE after IDAT, is now rejected. Pillow loads such files, so this needs its own check.check_listing): rejects any character in Unicode categories C* (control, and format, which covers zero-width space/joiner, BOM, word joiner and soft hyphen) or Z* (separators), plus port:0..github/workflows/test.yml): on pull requests and pushes to main, installsscripts/requirements.txtand the Codex CLI, runspython -m unittest discover -s tests -vand builds the ChatGPT ZIP. Before this PR, the only checks were CodeQL.Checks
python3 -m unittest tests.test_chatgpt_packagegave 16 tests, 2 failures:test_build_refuses_bad_listing_metadata(SystemExit not raised : https://reasonmachines.com:0) andtest_build_refuses_palette_png_without_plte. A probe also showed fecf24a accepting URLs with U+200B, U+200D, U+FEFF, U+2060 and U+00AD.PATH=~/.local/bin:$PATH python3 -m unittest discover -s testsgave 30 tests, OK (Python 3.11.2, Pillow 13, codex-cli 0.167.2).python3 scripts/build_chatgpt_zip.pyproduced the same 7 files, sha256c92c6ef2…7dae3d, byte-identical to the Directory submission package, hexagon logo and 1.3.0 listing update #22 build.Exact-head independent review and final CI
16b1479f: no blocking findings in the three-item scope. Reviewer independently reproduced both regressions failing onfecf24aand passing on this head; exercised every added malformed URL case across all four URL fields and valid palette PNGs.python3 -m unittest discover -s testsin a fresh virtual environment: 30 tests PASS.python3 scripts/build_chatgpt_zip.py /tmp/reason-pr23-head-venv.zip: PASS, seven files, byte-identical to the base ZIP. Confirmed source and packaged manifests omitreview.test_cases, and only the three scoped files differ.16b1479f: test, CodeQL, Analyze (python), Analyze (actions). Test workflow run confirms all 30 tests and the ZIP build pass on the standard PR merge ref.