fix(github): resume installation permission upgrades - #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
GitHub App permission increases now target the exact installation instead of the new-install account selector. The Adapter keeps the original authorization intent on a waiting page, observes the signed
new_permissions_acceptedwebhook, and resumes the same Realmroot approval automatically.The permission-review URL is derived from the canonical installation
html_url, so personal and organization installations use their correct GitHub settings paths.Review-environment acceptance
adapters.realmroot.devwith an existing personal or organization GitHub App installation.realmroot agent request.realmroot exec github --context <context> -- gh api ...operation requiring that permission.Verification
pnpm run docs:checkpnpm run typecheckpnpm run lintpnpm run test:unit(161 tests)pnpm run test:integration(15 tests)pnpm run buildsaltbo(152267965): permission update, automatic transaction resume, Agent authorization, and provider API reachability passed.realmroot(152329382): canonical organization permission URL, automatic transaction resume, andGET /repos/realmroot/adapters/rulesetsreturned200.🤖 Created by Jarvis via Realmroot