Repository navigation
F7: a set inside a root complex is one node fed by its members (OR), not every member a required input (deltasignal specs/044) - #105
Merged
Conversation
…not every member a required input _decompose_hier flattened a set component into its members, each emitted as an AND assembly input of the complex, so a knockout of one alternative removed the complex (VAV1 effectors:GDP needed all five GTPases). A set component is now one node: members feed it over set_member/OR edges (built like components: an existing node, a nested complex, a nested set, or a leaf) and it is the complex's AND input. All in boundary_edges.csv. How members combine is the consumer's set-pool rule (deltasignal specs/033, default product), so this is a structural change; deltasignal specs/044 measures whether predictions move. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes code-review finding F7.
_decompose_hierflattened a set component of a root complex into its members, and emitted each one as a requiredandassembly input. Knocking out one alternative then removed the whole complex: "VAV1 Rho/Rac effectors:GDP" needed all five GTPases.A set component is now one node:
set_member/oredges;andinput.Modifier-isoform sets stay atomic, and all of this lives in
boundary_edges.csv. How the members combine is the consumer's set-pool rule (deltasignal specs/033,productby default).Measured (deltasignal specs/044 research.md, pre-registered). Builds
20261003-1058_1491276_f7ctrland20261003-1113_83a71a2_f7set, same generator commit otherwise:Both are within the noise floor. Traced: one faithful new join, Cyclin E:p-T160-CDK2 into its "CCNA/CCNE:p-T160-CDK2" set, adds a route into Mitotic G1's CDK2 loop. The TP53 swing under the production sweep is node-label noise and disappears under the label-independent sweep.
Tests:
tests/test_boundary_set_nodes.py, 4 tests. Three fail on the old code; the fourth checks boundary tagging and passes on both. 344 passed.🤖 Generated with Claude Code