Repository navigation
Spec 010 T054–T055: local uploads, and the site server's proxy package - #508
Merged
Merged
Conversation
… package - local.conf sets client_max_body_size 64m, as every deployment does: it set nothing, so nginx's 1 MB default refused local uploads that the deployments accept. limits.spec.ts now holds every configuration, local included, to at least Java's 50 MiB upload cap (shown failing on local.conf first). - serve-prod.js, the production site server, requires http-proxy-middleware, which was installed only as a dev package of another tool. It is now a declared dependency, at the 3.0.7 already resolved. The lockfile changes nothing but the dev flag on it and the four packages it needs at run time: no name or version moved at any depth (diffed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It matched only values written as "64m", so a smaller limit written as 512k (or a bare byte count) passed unseen. Every value is now converted from its unit; one it cannot read fails. Shown: 512k and a garbage value fail, 64M and 1g pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two side findings from spec 010's research.
local.confnow setsclient_max_body_size 64m, matching every deployment. It set nothing before, so nginx's 1 MB default refused local uploads that the deployments accept.limits.spec.tsnow requires every configuration, local included, to allow at least Java's own 50 MiB upload cap. The test was shown failing onlocal.conffirst.serve-prod.jsis the production site server. It requireshttp-proxy-middleware, which was installed only as a dev package of another tool. It is now a declared dependency, pinned at the 3.0.7 already resolved.🤖 Generated with Claude Code