Skip to content

Fix use-after-free race in RCTInstance callFunctionOnJSModule (#58816) #58816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zeyap wants to merge 1 commit into from
Closed

Fix use-after-free race in RCTInstance callFunctionOnJSModule (#58816) #58816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,14 @@ - (void)dealloc

- (void)callFunctionOnJSModule:(NSString *)moduleName method:(NSString *)method args:(NSArray *)args
{
if (_valid) {
_reactInstance->callFunctionOnModule(
[moduleName UTF8String], [method UTF8String], convertIdToFollyDynamic(args ? args : @[]));
// This is called from arbitrary threads, while -invalidate destroys _reactInstance on
// the JS thread, so checking _valid and dereferencing have to happen as one step.
std::lock_guard<std::mutex> lock(_invalidationMutex);
if (!_valid || !_reactInstance) {
return;
}
_reactInstance->callFunctionOnModule(
[moduleName UTF8String] ?: "", [method UTF8String] ?: "", convertIdToFollyDynamic(args ? args : @[]));
}

- (void)invalidate
Expand Down
Loading