Skip to content

Use public umbrellas in animationbackend headers (#58734) #58734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −9
Open

Use public umbrellas in animationbackend headers (#58734) #58734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-native/ReactCommon/React-Fabric.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ Pod::Spec.new do |s|
end

s.subspec "animationbackend" do |ss|
ss.dependency "React-Fabric/coreUmbrella"
ss.dependency "React-Fabric/components/viewUmbrella"
ss.dependency "React-callinvoker"
ss.dependency "React-timing"
ss.source_files = podspec_sources("react/renderer/animationbackend/**/*.{m,mm,cpp,h}", "react/renderer/animationbackend/**/*.{h}")
ss.header_dir = "react/renderer/animationbackend"
end
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedProps.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/renderer/components/view/BaseViewProps.h>
#include <React/View.h>

#include <utility>

Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsBuilder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/renderer/components/view/BaseViewProps.h>
#include <react/renderer/graphics/Filter.h>
#include <React/Graphics.h>
#include <React/View.h>
#include "AnimatedProps.h"

namespace facebook::react {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <React/RendererCore.h>
#include <React/View.h>
#include <folly/dynamic.h>
#include <react/renderer/components/view/BaseViewProps.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <react/renderer/uimanager/UIManager.h>
#include <react/renderer/uimanager/UIManagerCommitHook.h>
#include "AnimatedProps.h"
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <ReactCommon/CallInvoker.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <React/CallInvoker.h>
#include <React/RendererCore.h>
#include <react/renderer/uimanager/UIManager.h>
#include <react/renderer/uimanager/UIManagerAnimationBackend.h>
#include <functional>
Expand Down
2 changes: 1 addition & 1 deletion ...ges/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/renderer/core/ReactPrimitives.h>
#include <React/RendererCore.h>
#include <react/renderer/uimanager/UIManager.h>
#include <react/renderer/uimanager/UIManagerCommitHook.h>
#include "AnimatedPropsRegistry.h"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationChoreographer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <React/Timing.h>
#include <react/renderer/uimanager/UIManagerAnimationBackend.h>
#include <react/timing/primitives.h>

namespace facebook::react {

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/animationbackend/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,15 @@ add_library(react_renderer_animationbackend OBJECT ${react_renderer_animationbac
target_include_directories(react_renderer_animationbackend PUBLIC ${REACT_COMMON_DIR})

target_link_libraries(react_renderer_animationbackend
callinvoker
react_codegen_rncore
react_cxxstableapi
react_debug
react_renderer_core
react_renderer_graphics
react_renderer_mounting
react_renderer_uimanager
react_timing
glog
folly_runtime
)
Expand Down
Loading