Conversation
Summary: React Native for Android supports API 24 and newer. Remove the API-23-only `I18nUtil` Robolectric test because running the shared unit suite against that unsupported runtime fails while parsing the package manifest. Restore the test target to its supported SDK and dependency set while leaving the production `ConfigurationCompat` fix unchanged. Changelog: [Internal] - Remove an unsupported API 23 Robolectric test. Differential Revision: D122276097
meta-cla
Bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122276097. |
|
This pull request has been merged in ff19940. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
React Native for Android supports API 24 and newer. Remove the API-23-only
I18nUtilRobolectric test because running the shared unit suite against thatunsupported runtime fails while parsing the package manifest. Restore the test
target to its supported SDK and dependency set while leaving the production
ConfigurationCompatfix unchanged.Changelog:
[Internal] - Remove an unsupported API 23 Robolectric test.
Differential Revision: D122276097