-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Fix iOS RefreshControl appearance after native navigation #58694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
camchis
wants to merge
1
commit into
react:main
Choose a base branch
from
camchis:fix/ios-refresh-control-appearance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+163
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
115 changes: 115 additions & 0 deletions
115
packages/react-native/React/Tests/Mounting/RCTPullToRefreshViewComponentViewTests.mm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| /* | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| #import <React/RCTPullToRefreshViewComponentView.h> | ||
| #import <React/RCTScrollViewComponentView.h> | ||
| #import <XCTest/XCTest.h> | ||
| #import <react/renderer/components/FBReactNativeSpec/Props.h> | ||
| #import <react/renderer/graphics/Color.h> | ||
|
|
||
| using namespace facebook::react; | ||
|
|
||
| #if TARGET_OS_IOS | ||
|
|
||
| @interface RCTPullToRefreshViewComponentViewTests : XCTestCase | ||
| @end | ||
|
|
||
| @implementation RCTPullToRefreshViewComponentViewTests | ||
|
|
||
| - (void)testBackgroundColorIsForwardedUpdatedAndRemoved | ||
| { | ||
| RCTScrollViewComponentView *scrollView = [RCTScrollViewComponentView new]; | ||
| RCTPullToRefreshViewComponentView *component = [RCTPullToRefreshViewComponentView new]; | ||
| [scrollView addSubview:component]; | ||
|
|
||
| auto props = std::make_shared<PullToRefreshViewProps>(); | ||
| props->backgroundColor = colorFromRGBA(255, 0, 0, 255); | ||
| [component updateProps:props oldProps:nullptr]; | ||
| XCTAssertEqualObjects(scrollView.scrollView.refreshControl.backgroundColor, UIColor.redColor); | ||
|
|
||
| auto updatedProps = std::make_shared<PullToRefreshViewProps>(*props); | ||
| updatedProps->backgroundColor = colorFromRGBA(0, 0, 255, 255); | ||
| [component updateProps:updatedProps oldProps:props]; | ||
| XCTAssertEqualObjects(scrollView.scrollView.refreshControl.backgroundColor, UIColor.blueColor); | ||
|
|
||
| auto defaultProps = std::make_shared<PullToRefreshViewProps>(); | ||
| [component updateProps:defaultProps oldProps:updatedProps]; | ||
| XCTAssertNil(scrollView.scrollView.refreshControl.backgroundColor); | ||
| } | ||
|
|
||
| - (void)testExplicitAppearanceIsRestoredWhenReturningToWindow | ||
| { | ||
| UIWindow *window = [[UIWindow alloc] initWithFrame:CGRectMake(0, 0, 100, 100)]; | ||
| RCTScrollViewComponentView *scrollView = [RCTScrollViewComponentView new]; | ||
| RCTPullToRefreshViewComponentView *component = [RCTPullToRefreshViewComponentView new]; | ||
| auto props = std::make_shared<PullToRefreshViewProps>(); | ||
| props->backgroundColor = colorFromRGBA(255, 0, 0, 255); | ||
| props->tintColor = colorFromRGBA(0, 0, 255, 255); | ||
| props->title = "React title"; | ||
| props->titleColor = colorFromRGBA(0, 255, 0, 255); | ||
| [component updateProps:props oldProps:nullptr]; | ||
| [scrollView addSubview:component]; | ||
| [window addSubview:scrollView]; | ||
| UIRefreshControl *control = scrollView.scrollView.refreshControl; | ||
|
|
||
| [scrollView removeFromSuperview]; | ||
| // Simulate native appearance changes without leaking a global UIAppearance | ||
| // proxy into other tests. Reattaching must restore the unchanged React props. | ||
| control.backgroundColor = UIColor.blackColor; | ||
| control.tintColor = UIColor.blackColor; | ||
| control.attributedTitle = | ||
| [[NSAttributedString alloc] initWithString:@"Native title" | ||
| attributes:@{NSForegroundColorAttributeName : UIColor.blackColor}]; | ||
| [window addSubview:scrollView]; | ||
|
|
||
| XCTAssertEqual(control, scrollView.scrollView.refreshControl); | ||
| XCTAssertEqualObjects(control.backgroundColor, UIColor.redColor); | ||
| XCTAssertEqualObjects(control.tintColor, UIColor.blueColor); | ||
| XCTAssertEqualObjects(control.attributedTitle.string, @"React title"); | ||
| XCTAssertEqualObjects( | ||
| [control.attributedTitle attribute:NSForegroundColorAttributeName atIndex:0 effectiveRange:nil], | ||
| UIColor.greenColor); | ||
| } | ||
|
|
||
| - (void)testUnspecifiedAppearanceIsNotOverriddenWhenReturningToWindow | ||
| { | ||
| UIWindow *window = [[UIWindow alloc] initWithFrame:CGRectMake(0, 0, 100, 100)]; | ||
| RCTScrollViewComponentView *scrollView = [RCTScrollViewComponentView new]; | ||
| RCTPullToRefreshViewComponentView *component = [RCTPullToRefreshViewComponentView new]; | ||
| [scrollView addSubview:component]; | ||
| UIRefreshControl *control = scrollView.scrollView.refreshControl; | ||
| control.backgroundColor = UIColor.redColor; | ||
| control.tintColor = UIColor.blueColor; | ||
| control.attributedTitle = [[NSAttributedString alloc] initWithString:@"Native default"]; | ||
| [window addSubview:scrollView]; | ||
|
|
||
| XCTAssertEqualObjects(control.backgroundColor, UIColor.redColor); | ||
| XCTAssertEqualObjects(control.tintColor, UIColor.blueColor); | ||
| XCTAssertEqualObjects(control.attributedTitle.string, @"Native default"); | ||
| } | ||
|
|
||
| - (void)testBackgroundColorIsReappliedAfterRecycling | ||
| { | ||
| RCTScrollViewComponentView *scrollView = [RCTScrollViewComponentView new]; | ||
| RCTPullToRefreshViewComponentView *component = [RCTPullToRefreshViewComponentView new]; | ||
| auto props = std::make_shared<PullToRefreshViewProps>(); | ||
| props->backgroundColor = colorFromRGBA(255, 0, 0, 255); | ||
| [component updateProps:props oldProps:nullptr]; | ||
| [scrollView addSubview:component]; | ||
| UIRefreshControl *original = scrollView.scrollView.refreshControl; | ||
| [component removeFromSuperview]; | ||
| [component prepareForRecycle]; | ||
| [component updateProps:props oldProps:nullptr]; | ||
| [scrollView addSubview:component]; | ||
|
|
||
| XCTAssertNotEqual(original, scrollView.scrollView.refreshControl); | ||
| XCTAssertEqualObjects(scrollView.scrollView.refreshControl.backgroundColor, UIColor.redColor); | ||
| } | ||
|
|
||
| @end | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
RCTPullToRefreshcontrol does not exists.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RCTPullToRefreshControlis introduced above (lines 45-63)It subclasses
UIRefreshControlso we can reapply the React props indidMoveToWindowafter UIKit applies UIAppearance