Use umbrellas instead of direct includes in rendererdebug module (#58619) - #58619
Closed
j-piasecki wants to merge 2 commits into
Closed
j-piasecki wants to merge 2 commits into
j-piasecki wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121001495. |
meta-codesync
Bot
changed the title
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 22, 2026
…ct#58619) Summary: Changelog: [Internal] Update the rendererdebug module to use the `React/Debug.h` and `React/Utils.h` umbrella includes instead of direct ones. Differential Revision: D121001495
j-piasecki
force-pushed
the
export-D121001495
branch
from
September 22, 2026 13:14
e46c048 to
5b3fa0f
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 24, 2026
…ct#58619) Summary: Changelog: [Internal] Update the rendererdebug module to use the `React/Debug.h` and `React/Utils.h` umbrella includes instead of direct ones. Differential Revision: D121001495
j-piasecki
force-pushed
the
export-D121001495
branch
from
September 24, 2026 09:03
5b3fa0f to
853246b
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 24, 2026
…ct#58619) Summary: Changelog: [Internal] Update the rendererdebug module to use the `React/Debug.h` and `React/Utils.h` umbrella includes instead of direct ones. Differential Revision: D121001495
j-piasecki
force-pushed
the
export-D121001495
branch
from
September 24, 2026 09:06
853246b to
665c770
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 25, 2026
…ct#58619) Summary: Changelog: [Internal] Update the rendererdebug module to use the `React/Debug.h` and `React/Utils.h` umbrella includes instead of direct ones. Reviewed By: cipolleschi Differential Revision: D121001495
j-piasecki
force-pushed
the
export-D121001495
branch
from
September 25, 2026 13:08
665c770 to
f4a45d8
Compare
Summary: Apply the repository formatter to the iOS prebuild header documentation. This restores the expected Markdown line wrapping and the public format check. Changelog: [Internal] bypass-github-export-checks ___ Differential Revision: D121797341
…ct#58619) Summary: Changelog: [Internal] Update the rendererdebug module to use the `React/Debug.h` and `React/Utils.h` umbrella includes instead of direct ones. Reviewed By: cipolleschi Differential Revision: D121001495
j-piasecki
force-pushed
the
export-D121001495
branch
from
September 25, 2026 14:09
f4a45d8 to
17917d1
Compare
|
This pull request has been merged in 972860a. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Sep 30, 2026
…#58759) Summary: `React-utils`'s `platformios` subspec inherits `header_dir = "react/utils"` from the parent spec, and maps its headers relative to `platform/ios` — a directory whose own layout already begins with `react/utils`. Outside `use_frameworks!` both layers are applied in sequence (`PodTarget#header_mappings`), so `FollyConvert.h` / `LowPriorityExecutor.h` end up one level too deep: ``` Pods/Headers/{Public,Private}/React-utils/react/utils/react/utils/*.h ``` and the documented include path can no longer be resolved. Since #58619 the `react/utils` umbrella is reached through `react/renderer/debug/flags.h` and `debugStringConvertibleUtils.h`, so the failure is not limited to direct consumers of `react/utils`: in the default static configuration any pod that transitively includes those headers stops compiling, e.g. in target `React-ImageManager`: ``` Pods/Headers/Public/React-utils/React/Utils.h:36:10: fatal error: 'react/utils/LowPriorityExecutor.h' file not found ``` Inside `use_frameworks!` the framework header copy path only takes the mapping directory into account (`pod_target_installer#add_header`; `link_headers` skips framework targets, which is why `Pods/Headers` is empty there), so `platform/ios` is correct for that configuration and only the static layout is broken. The fix clears the inherited `header_dir` on that subspec instead of moving the mapping directory: the mapping already contributes the `react/utils` prefix, so the static layout becomes `Pods/Headers/Public/React-utils/react/utils/*.h` — the same place the module's other headers land — while the frameworks layout (`React_utils.framework/Headers/react/utils/*.h`) is unchanged, because `header_dir` does not participate in that path. `header_dir = ""` together with `header_mappings_dir = …` is also the convention the `*Umbrella` subspecs of this repo already use (`React-utils`, `React-Mapbuffer`, `React-FabricImage`, `ReactCommon`). ## Changelog: [iOS] [FIXED] - React-utils: link `platform/ios` headers at `react/utils/…` in non-frameworks builds instead of a duplicated `react/utils/react/utils/…`, restoring `#include <react/utils/…>` and `<React/Utils.h>` Pull Request resolved: #58759 Test Plan: RNTester using `pod install` or `USE_FRAMEWORKS=dynamic pod install` to build and can build successfully. Reviewed By: javache Differential Revision: D122536016 Pulled By: cipolleschi fbshipit-source-id: e0bf2a0ecef6e8db713a276eb9a2f07b5f2daad0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Update the rendererdebug module to use the
React/Debug.handReact/Utils.humbrella includes instead of direct ones.Reviewed By: cipolleschi
Differential Revision: D121001495