Skip to content

Move renderer color parsing out of headers (#58521) - #58521

Open
coado wants to merge 2 commits into
react:mainfrom
coado:export-D119500849
Open

coado wants to merge 2 commits into
react:mainfrom
coado:export-D119500849

Conversation

@coado

@coado coado commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

Move shared and platform-specific Graphics color-parsing implementations from exported headers into owned source files across generic C++, Android, Apple, and Windows targets. Preserve the existing public entry points and parsing behavior.

Update Buck source selection so default configurations link the generic C++ parser, and keep the React Native macOS and Windows mirrors synchronized.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D119500849

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2026
@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Sep 14, 2026
@meta-codesync

meta-codesync Bot commented Sep 14, 2026

Copy link
Copy Markdown

@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119500849.

coado added a commit to coado/react-native that referenced this pull request Sep 16, 2026
Summary:
Pull Request resolved: react#58521

Move shared and platform-specific Graphics color-parsing implementations from exported headers into owned source files across generic C++, Android, Apple, and Windows targets. Preserve the existing public entry points and parsing behavior.

Update Buck source selection so default configurations link the generic C++ parser, and keep the React Native macOS and Windows mirrors synchronized.

Changelog: [Internal]

Differential Revision: D119500849
@meta-codesync meta-codesync Bot changed the title Move renderer color parsing out of headers Move renderer color parsing out of headers (#58521) Sep 16, 2026
coado added a commit to coado/react-native that referenced this pull request Sep 17, 2026
Summary:
Pull Request resolved: react#58521

Move shared and platform-specific Graphics color-parsing implementations from exported headers into owned source files across generic C++, Android, Apple, and Windows targets. Preserve the existing public entry points and parsing behavior.

Update Buck source selection so default configurations link the generic C++ parser, and keep the React Native macOS and Windows mirrors synchronized.

Changelog: [Internal]

Differential Revision: D119500849
Summary:
Declare direct CSS dependencies for renderer targets that consume CSS headers instead of relying on View or Graphics to expose them transitively. Cover Buck, CMake, CocoaPods, and SwiftPM without changing header visibility or runtime behavior.

Changelog: [Internal]

Differential Revision: D119489856
coado added a commit to coado/react-native that referenced this pull request Sep 28, 2026
Summary:

Move shared and platform-specific Graphics color-parsing implementations from exported headers into owned source files across generic C++, Android, Apple, and Windows targets. Preserve the existing public entry points and parsing behavior.

Update Buck source selection so default configurations link the generic C++ parser, and keep the React Native macOS and Windows mirrors synchronized.

Changelog: [Internal]

Differential Revision: D119500849
coado added a commit to coado/react-native that referenced this pull request Sep 28, 2026
Summary:
Pull Request resolved: react#58521

Move shared and platform-specific Graphics color-parsing implementations from exported headers into owned source files across generic C++, Android, Apple, and Windows targets. Preserve the existing public entry points and parsing behavior.

Update Buck source selection so default configurations link the generic C++ parser, and keep the React Native macOS and Windows mirrors synchronized.

Changelog: [Internal]

Differential Revision: D119500849
coado added a commit to coado/react-native that referenced this pull request Sep 29, 2026
Summary:

Move shared and platform-specific Graphics color-parsing implementations from exported headers into owned source files across generic C++, Android, Apple, and Windows targets. Preserve the existing public entry points and parsing behavior.

Update Buck source selection so default configurations link the generic C++ parser, and keep the React Native macOS and Windows mirrors synchronized.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D119500849
Summary:
Pull Request resolved: react#58521

Move shared and platform-specific Graphics color-parsing implementations from exported headers into owned source files across generic C++, Android, Apple, and Windows targets. Preserve the existing public entry points and parsing behavior.

Update Buck source selection so default configurations link the generic C++ parser, and keep the React Native macOS and Windows mirrors synchronized.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D119500849

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant