Skip to content

Syntax update for including style-loader#9632

Closed
rfreling wants to merge 1 commit into
react:masterfrom
rfreling:patch-1
Closed

Syntax update for including style-loader#9632
rfreling wants to merge 1 commit into
react:masterfrom
rfreling:patch-1

Conversation

@rfreling

@rfreling rfreling commented Sep 12, 2020

Copy link
Copy Markdown

Cleaned up PR (original reference #9076, stale PR #9100 )


This simple syntax change will allow for other CRA extension utilities (like customize-cra) to add options to the 'style-loader'. Specifically the "insert" prop (fka "insertInto") can be quite useful.

E.g. https://github.com/arackaf/customize-cra/blob/master/api.md#adjuststyleloaderscallback

It's possible that preventing overrides to the 'style-loader' configuration was intentional as a way to prevent downstream webpack/hot-update bugs, but I haven't run into any when running this update in an ejected create-react-app. So would appreciate any veteran thoughts on whether this is safe to update.

@rfreling

Copy link
Copy Markdown
Author

@mrmckeb I just remembered this one (#9076) and saw that it's sitting stale in the v4 Project Done kanban

Is it correct procedure to open this PR? Happy to support however you advise, but don't want to get in the way if already handled 👍

@mrmckeb

mrmckeb commented Sep 13, 2020

Copy link
Copy Markdown
Contributor

I'm OK with this change - but keep in mind that as we don't officially expose that config today, we can't guarantee that this will always be there.

@ianschmitz or @iansu, any thoughts?

@rfreling

Copy link
Copy Markdown
Author

@ianschmitz + @iansu Quickly bumping this in case you think it will be useful.

I was reminded to follow up after getting a notification that someone else would find this useful (stefangomez#1 (comment))

Thanks for considering!

cc @mrmckeb

@stale

stale Bot commented Dec 19, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale Bot added the stale label Dec 19, 2020
@stale

stale Bot commented Dec 25, 2020

Copy link
Copy Markdown

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale Bot closed this Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants