Small syntax update for including style-loader#9076
Conversation
This simple syntax change will allow for other CRA extension utilities (like customize-cra) to add options the 'style-loader'. E.g. https://github.com/arackaf/customize-cra/blob/master/api.md#adjuststyleloaderscallback
rfreling
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Hi @rfreling! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Looks like each of the Azure Devops Pipeline test run reports since Tuesday are failing with the same error: So, likely independent of this PR? |
|
Hi @rfreling, can you please rebase? That should fix the CI issue. |
* Fix dotenv file loading order * tests: fix failing env tests * tests: fix more failing tests Co-authored-by: Brody McKee <mrmckeb@hotmail.com>
|
Hi @rfreling, it looks like your rebase failed. I see commits/changes from outside of your branch. Can you take a look at cleaning this up? Sorry for the troubles. |
6 participants
Hi team 👋
This simple syntax change will allow for other CRA extension utilities (like customize-cra) to add options the 'style-loader'. Specifically the "insert" prop (fka "insertInto") can be quite useful.
E.g. https://github.com/arackaf/customize-cra/blob/master/api.md#adjuststyleloaderscallback
It's possible that preventing overrides to the 'style-loader' configuration was intentional as a way to prevent downstream webpack/hot-update bugs, but I haven't run into any when running this update in an ejected create-react-app. So would appreciate any veteran thoughts on whether this is safe to update.
Thanks for considering!