Removed errors#7895
Closed
Priyanshu2001 wants to merge 4 commits into
Closed
Conversation
create react-app >>> create-react-app Sourcemaps >>> source maps webkit >>>> Web kit
|
Hi Priyanshu2001! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Contributor
|
Thanks for your submission! I can see the confusion but its actually correct, check https://yarnpkg.com/lang/en/docs/cli/create/ Can you revert that one and keep the other typo fixes? Thanks! |
iansu
reviewed
Oct 30, 2019
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
andriijas
suggested changes
Nov 6, 2019
andriijas
left a comment
andriijas
left a comment
Contributor
There was a problem hiding this comment.
Hi @Priyanshu2001 - Can you update the PR with suggested changes? Thanks!
Author
|
Okk!!
I have done it sir.
Hope you will merge now.
Thank you!
…On Wed, Nov 6, 2019, 14:01 Andreas Cederström ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi @Priyanshu2001 <https://github.com/Priyanshu2001> - Can you update the
PR with suggested changes? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7895>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANMCBBIRIZZW44FB4ZKM5HLQSJ6HVANCNFSM4JGGA62A>
.
|
andriijas
suggested changes
Nov 6, 2019
| - React, JSX, ES6, TypeScript and Flow syntax support. | ||
| - Language extras beyond ES6 like the object spread operator. | ||
| - Autoprefixed CSS, so you don’t need `-webkit-` or other prefixes. | ||
| - Autoprefixed CSS, so you don’t need `-WebKit-` or other prefixes. |
| - A fast interactive unit test runner with built-in support for coverage reporting. | ||
| - A live development server that warns about common mistakes. | ||
| - A build script to bundle JS, CSS, and images for production, with hashes and sourcemaps. | ||
| - A build script to bundle JS, CSS, and images for production, with hashes and source maps. |
| We'd love to have your helping hand on `create react-app`! See [CONTRIBUTING.md](CONTRIBUTING.md) for more information on what we're looking for and how to get started. | ||
|
|
||
| ## React Native | ||
| ## React Native :- |
| - [@mxstbr](https://github.com/mxstbr) | ||
|
|
||
| ## License | ||
| ## License :- |
Contributor
There was a problem hiding this comment.
Please revert this, thanks
Author
|
Done sir!
…On Wed, Nov 6, 2019, 19:35 Andreas Cederström ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In README.md
<#7895 (comment)>
:
> @@ -145,10 +145,10 @@ Your environment will have everything you need to build a modern single-page Rea
- React, JSX, ES6, TypeScript and Flow syntax support.
- Language extras beyond ES6 like the object spread operator.
-- Autoprefixed CSS, so you don’t need `-webkit-` or other prefixes.
+- Autoprefixed CSS, so you don’t need `-WebKit-` or other prefixes.
Nice catch!
------------------------------
In README.md
<#7895 (comment)>
:
> - A fast interactive unit test runner with built-in support for coverage reporting.
- A live development server that warns about common mistakes.
-- A build script to bundle JS, CSS, and images for production, with hashes and sourcemaps.
+- A build script to bundle JS, CSS, and images for production, with hashes and source maps.
Nice catch!
------------------------------
In README.md
<#7895 (comment)>
:
>
-## React Native
+## React Native :-
Please revert this
------------------------------
In README.md
<#7895 (comment)>
:
> @@ -199,6 +199,6 @@ We are grateful to the authors of existing related projects for their ideas and
- ***@***.***(https://github.com/insin)
- ***@***.***(https://github.com/mxstbr)
-## License
+## License :-
Please revert this, thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7895>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANMCBBMLDONWYKWUHQW43WDQSLFKHANCNFSM4JGGA62A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create react-app >>> create-react-app
Sourcemaps >>> source maps
webkit >>>> Web kit